Feature/bsp stop transaction #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
requested review from
SebaLukas,
Pietfried and
hikinggrass
as code owners
Pietfried
approved these changes
Jun 24, 2024
Signed-off-by: Cornelius Claussen <[email protected]>
Signed-off-by: Cornelius Claussen <[email protected]>
corneliusclaussen
force-pushed
the
feature/bsp-stop-transaction
branch
from
f14c86a to
576a33a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Allow the BSP to stop the transaction. In many cases the MCU that is handling the CP signal etc also handles the stop charging button (and or the emergency stop button). With this change it can stop gracefully in case of normal stop button and report an emergency shutdown (after the MCU already performed it)
Issue ticket number and link
Checklist before requesting a review