Bugfix/remove exits #713
Merged
Bugfix/remove exits #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
force-pushed
the
bugfix/remove-exits
branch
2 times, most recently
from
8b4be27 to
ad82eb7
Compare
corneliusclaussen
requested review from
hikinggrass,
SebaLukas,
a-w50 and
Pietfried
as code owners
hikinggrass
approved these changes
Jun 7, 2024
a-w50
force-pushed
the
bugfix/remove-exits
branch
from
ad82eb7 to
0d877b3
Compare
corneliusclaussen
force-pushed
the
bugfix/remove-exits
branch
2 times, most recently
from
f19e743 to
4f93cc3
Compare
- BSPs - SerialCommHub - System - PacketSniffer - Ev/EvseSlac Signed-off-by: Cornelius Claussen <[email protected]>
corneliusclaussen
force-pushed
the
bugfix/remove-exits
branch
from
4f93cc3 to
dc37686
Compare
Pietfried
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Several modules exit() (directly or through unhandled exceptions) in case or errors. This PR removes some of them and tries to handle them, e.g. by raising an error and keeping the module running.
In a next step, modules should be more tolerant to faults (e.g. retry opening uart ports if the device is not available at the moment).
Issue ticket number and link
Checklist before requesting a review