Rename UINT32_MAX as it collides with definition in /usr/include/stdi… #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebaLukas
reviewed
Jun 7, 2024
modules/EvseV2G/v2g_server.cpp
Outdated
| @@ -163,7 +163,7 @@ static int v2g_incoming_v2gtp(struct v2g_connection* conn) { | |||
| return -1; | |||
| } | |||
|
|
|||
| if (conn->payload_len >= UINT32_MAX - V2GTP_HEADER_LENGTH) { | |||
| if (conn->payload_len >= _UINT32_MAX - V2GTP_HEADER_LENGTH) { | |||
There was a problem hiding this comment.
Good catch! We could also use UINT32_MAX from stdint instead of adding a extra define
There was a problem hiding this comment.
true, changed to the system one
Signed-off-by: Cornelius Claussen <[email protected]>
|
|
corneliusclaussen
force-pushed
the
bugfix/rename-UINT32_MAX
branch
from
3a82b69 to
a2c4203
Compare
hikinggrass
approved these changes
Jun 7, 2024
|
Closed in favour of #715 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nt.h
UINT32_MAX is already defined in a system header
Describe your changes
Issue ticket number and link
Checklist before requesting a review