Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend PhyVersoBSP with PpState, Temperature and OpaqueData #687

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Extend PhyVersoBSP with PpState, Temperature and OpaqueData #687

merged 6 commits into from
Jun 6, 2024

Conversation

dorezyuk
Copy link
Contributor

@dorezyuk dorezyuk commented May 15, 2024 •
edited
Loading

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@barsnick barsnick changed the title Extend PhyversBSP with PpState, Temperature and OpaqueData Extend PhyVersoBSP with PpState, Temperature and OpaqueData May 15, 2024
@dorezyuk dorezyuk marked this pull request as ready for review May 28, 2024 14:16
corneliusclaussen
corneliusclaussen approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@corneliusclaussen corneliusclaussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like generic arrays and interfaces that publish undocumented data. But see the need here and I don't have a better idea on how to do this either ;-)

Dima Dorezyuk added 5 commits June 5, 2024 13:00
@corneliusclaussen
Extend PhyversBSP with PpState, Temperature and OpaqueData
f363a1a 
Signed-off-by: Dima Dorezyuk <[email protected]>
@corneliusclaussen
fix format
ac0c6a1 
Signed-off-by: Dima Dorezyuk <[email protected]>
@corneliusclaussen
fix bazel
e6e081e 
Signed-off-by: Dima Dorezyuk <[email protected]>
@corneliusclaussen
fix build
ba63861 
Signed-off-by: Dima Dorezyuk <[email protected]>
@corneliusclaussen
update the protobuf file
06276d5 
Signed-off-by: Dima Dorezyuk <[email protected]>
@corneliusclaussen corneliusclaussen force-pushed the feat/extend_phyverso_bsp branch from 86ead2d to 06276d5 Compare June 5, 2024 11:00
@dorezyuk dorezyuk merged commit 16d4162 into main Jun 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusclaussen corneliusclaussen corneliusclaussen approved these changes

@golovasteek golovasteek golovasteek approved these changes

@SirVer SirVer SirVer approved these changes

@Pietfried Pietfried Awaiting requested review from Pietfried Pietfried is a code owner

@hikinggrass hikinggrass Awaiting requested review from hikinggrass hikinggrass is a code owner

Assignees

@hikinggrass hikinggrass

@corneliusclaussen corneliusclaussen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dorezyuk @SirVer @golovasteek @corneliusclaussen @hikinggrass