Refactored mutex locking in Auth module #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Passing a std::unique_lock to be able to use it inside a wait_for inside select_evse * Adding a check in the Connector so that an EVSE that already has an identifier assigned is not considered available Signed-off-by: Piet Gömpel <[email protected]>
Pietfried
force-pushed
the
refactor/auth-module-lock
branch
from
54677e5 to
5c8535f
Compare
Pietfried
requested review from
corneliusclaussen and
hikinggrass
as code owners
hikinggrass
approved these changes
Jan 8, 2025
Pietfried
added a commit
that referenced
this pull request
Jan 15, 2025
* Passing a std::unique_lock to be able to use it inside a wait_for inside select_evse * Adding a check in the Connector so that an EVSE that already has an identifier assigned is not considered available Signed-off-by: Piet Gömpel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review