lib/staging/slac: avoid warnings by using modern iterator

Signed-off-by: Moritz Barsnick <[email protected]>
EVerest · Jun 17, 2024 · 2e122a8 · 2e122a8
1 parent 7af9470
commit 2e122a8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/staging/slac/fsm/ev/src/states/others.cpp b/lib/staging/slac/fsm/ev/src/states/others.cpp
@@ -57,8 +57,8 @@ void InitSlacState::enter() {
     std::mt19937 rng(rnd_dev());
     std::uniform_int_distribution<std::mt19937::result_type> dist256(0, 255);
 
-    for (auto i = 0; i < sizeof(run_id); ++i) {
-        run_id[i] = dist256(rng);
+    for (auto& id : this->run_id) {
+        id = dist256(rng);
     }
 }
 

diff --git a/lib/staging/slac/fsm/ev/src/states/sounding.cpp b/lib/staging/slac/fsm/ev/src/states/sounding.cpp
@@ -103,8 +103,8 @@ bool SoundingState::do_sounding() {
         std::mt19937 rng(rnd_dev());
         std::uniform_int_distribution<std::mt19937::result_type> dist256(0, 255);
 
-        for (auto i = 0; i < sizeof(msg.random); ++i) {
-            msg.random[i] = dist256(rng);
+        for (auto& random : msg.random) {
+            random = dist256(rng);
         }
 
         ctx.send_slac_message(session_parameters.evse_mac, msg);