Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dead-time time-block #77

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add dead-time time-block #77

wants to merge 4 commits into from

Conversation

KrisThielemans
Copy link
Contributor

Changes in this pull request

add a DeadTimeTimeBlock. Needed to change all time-blocks to use TimeInterval as opposed to only giving the start time.

Testing performed

Generated/analysed files. (Used the C++ code with BinaryReader to test the python output).

Related issues

Fixes #75

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • The code builds and runs on my machine

Contribution Notes

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in the ETSI software (the Work) under the terms and conditions of the Apache-2.0 License.

Needed to change all time-blocks to use TimeInterval as opposed to
only giving the start time.

Fixes #75
@KrisThielemans
Copy link
Contributor Author

@johnstairs @naegelejd I had to comment out these

PETSIRD/model/Protocol.yml

Lines 101 to 104 in 2b3f776

# TODO currently commented out due to yardl proble=m (?)
# computedFields:
# sizeOfDetectorIdDimension: size(singlesAliveTimeFraction, 'detectorId')
# sizeOfEnergyIdxDimension: size(singlesAliveTimeFraction, 'energyIdx')

Otherwise I get a cryptic yardl error on generation:

~/devel/yardl-bin/yardl generate
ERR  /home/sirfuser/devel/PETSIRD/model/Protocol.yml:103:6: unrecognized type kind '!!map

syntax error or yardl bug?

@naegelejd
Copy link
Contributor

The parser error message could be more useful.

You just need to match the indentation of computedFields: with fields:.

@KrisThielemans
Copy link
Contributor Author

oops

@KrisThielemans
Copy link
Contributor Author

Currently keeping ScannerInformation.event_time_block_duration. This is however redundant information (if there is at least one event time-block present), so it could be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add dead-time information
2 participants