TimeBlock types #34
Merged
TimeBlock types #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fix an error where "start" is already in ms
KrisThielemans
commented
Oct 26, 2024
Comment on lines
+170
to
+176
| ( | ||
| petsird.TimeBlock.EventTimeBlock( | ||
| petsird.EventTimeBlock( | ||
| start=start, prompt_events=prompts_this_block | ||
| ) | ||
| ), | ||
| ) |
There was a problem hiding this comment.
This syntax works, but is a bit awkward. @johnstairs can this be simplified? (I didn't find any doc on creating unions at https://microsoft.github.io/yardl/python/language.html#generated-union-types)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces different types of
TimeBlocks, one for coincidence/triple events, one for external signals, one for bed movement and one for gantry movement.Having different types makes sure that we can have different time resolution for the different types, e.g. different external signals will have different sampling rates etc.
We have chosen to signals to be a union of different types as well. Alternatively, we could have introduced different types of
signalTimeBlock. However, that seems to need moreifstatements in the main loop (one for every signal-type), which could be more wasteful and less future proof, but maybe it's just a matter of taste...