Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building from .devcontainer failing when repository downloaded on Windows #12

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

Imraj-Singh
Copy link
Contributor

Changes in this pull request

Added .gitattributes for .sh .csh and .bashrc setting the eol as lf.

I noticed that git tracks all the code in the repository as modified with this solution, and one needs to set: git config --global core.autocrlf true to stop this...

Testing performed

Rebuilt the container and it did not break, I was able to use yardl.

Related issues

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • The code builds and runs on my machine

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in the ETSI software (the Work) under the terms and conditions of the Apache-2.0 License.

@KrisThielemans KrisThielemans merged commit df9e265 into ETSInitiative:main Nov 10, 2023
1 check passed
@KrisThielemans
Copy link
Contributor

feel like doing the same for https://github.com/ETSInitiative/PETSIRDUseCaseTemplate/?

@KrisThielemans
Copy link
Contributor

I noticed that git tracks all the code in the repository as modified with this solution, and one needs to set: git config --global core.autocrlf true to stop this...

This didn't happen for me (on Windows)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants