Merge pull request #73 from sstute1/bug_fix_helpers_cpp_get_det_effic…

…iency Bug fix in petsird_helpers.h for detection efficiencies
ETSInitiative · Dec 5, 2024 · 3eed512 · 3eed512
2 parents c5b0e46 + 2b0ac45
commit 3eed512
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/cpp/petsird_helpers.h b/cpp/petsird_helpers.h
@@ -56,16 +56,16 @@ get_detection_efficiency(const ScannerInformation& scanner, const CoincidenceEve
 {
   float eff = 1.0F;
   const auto& det_el_efficiencies = scanner.detection_efficiencies.det_el_efficiencies;
-  if (!det_el_efficiencies)
+  if (det_el_efficiencies)
     {
       eff *= ((*det_el_efficiencies)(event.detector_ids[0], event.energy_indices[0])
               * (*det_el_efficiencies)(event.detector_ids[1], event.energy_indices[1]));
     }
   const auto& module_pair_efficiencies_vector = scanner.detection_efficiencies.module_pair_efficiencies_vector;
-  if (!module_pair_efficiencies_vector)
+  if (module_pair_efficiencies_vector)
     {
       const auto& module_pair_SGID_LUT = scanner.detection_efficiencies.module_pair_sgidlut;
-      assert(!module_pair_SGID_LUT);
+      assert(module_pair_SGID_LUT);
 
       const auto mod_and_els = get_module_and_element(scanner.scanner_geometry, event.detector_ids);
       assert(scanner.scanner_geometry.replicated_modules.size() == 1);