Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a namelist warning when hillslope hydrology is used with initial interpolation. #2703

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

mvdebolskiy
Copy link
Contributor

@mvdebolskiy mvdebolskiy commented Aug 15, 2024

Description of changes

Added warning to CLMBuildNamelist.pm and a warning test in build-namelist_test.pl.

Specific notes

The warning is added after logic for initial conditions is done.

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):

Fixes #1806

Are answers expected to change (and if so in what way)?

No.

Any User Interface Changes (namelist or namelist defaults changes)?

You have to run ./xmlchange --append CLM_BLDNML_OPTS=-ignore_warnings if you want to have use_init_interp with use_hillslope both true.

Does this create a need to change or add documentation? Did you do so?

Testing performed, if any:

ran build-namelist_test.pl and tested a new case with above namelist changes

@mvdebolskiy mvdebolskiy requested a review from samsrabin August 15, 2024 19:22
@mvdebolskiy mvdebolskiy added simple bfb bit-for-bit labels Aug 15, 2024
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be rebased to b4b-dev, but otherwise this is great.

@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Aug 22, 2024
@samsrabin samsrabin marked this pull request as draft August 22, 2024 15:26
@samsrabin
Copy link
Collaborator

Converting to draft, pending the rebase.

@mvdebolskiy mvdebolskiy changed the base branch from master to b4b-dev August 22, 2024 15:58
@samsrabin samsrabin marked this pull request as ready for review August 22, 2024 16:43
@samsrabin samsrabin removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 12, 2024
Copy link
Collaborator

@samsrabin samsrabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go, pending your merge of mvdebolskiy#6.

hs-uii: Merge in latest b4b-dev
@samsrabin samsrabin merged commit a1ee963 into ESCOMP:b4b-dev Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get init_interp working correctly with hillslope initial conditions files
3 participants