Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reapply upgrades and add msw #459

Merged
merged 8 commits into from
Jul 9, 2024
Merged

feat: Reapply upgrades and add msw #459

merged 8 commits into from
Jul 9, 2024

Conversation

richtera
Copy link
Collaborator

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

fix: Upgrade npm modules, fix test scripts, add some exports, fix LF JSON parsing issue

What is the current behaviour (you can also link to an open issue here)?

What is the new behaviour (if this is a feature change)?

Other information:

Copy link
Collaborator

@CJ42 CJ42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added review comments

examples/package.json Show resolved Hide resolved
examples/package.json Show resolved Hide resolved
examples/src/instantiation.js Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/lib/_test.ts Outdated Show resolved Hide resolved
src/lib/encodeKeyName.ts Outdated Show resolved Hide resolved
src/lib/encodeKeyName.ts Show resolved Hide resolved
src/lib/getDataFromExternalSources.ts Show resolved Hide resolved
@richtera richtera changed the title feat: Reapply upgrades and add mpw feat: Reapply upgrades and add msw Jun 24, 2024
src/index.test.ts Outdated Show resolved Hide resolved
src/provider/providerWrapper.test.ts Show resolved Hide resolved
src/provider/providerWrapper.ts Show resolved Hide resolved
richtera and others added 3 commits June 28, 2024 21:32
Copy link
Collaborator Author

@richtera richtera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a follow up PR to talk about this. It seems large and it pulled in required changes to make all the parse decode runnable.

src/index.test.ts Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/index.test.ts Outdated Show resolved Hide resolved
@CJ42 CJ42 merged commit 8a397ef into develop Jul 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants