Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

57 create cli wbaccinelli #58

Merged
merged 7 commits into from
Jul 5, 2024
Merged

57 create cli wbaccinelli #58

merged 7 commits into from
Jul 5, 2024

Conversation

wbaccinelli
Copy link
Collaborator

Added CLI to run the dashboard. After installing the dashboard package with pip install ., the dashboard can be run using the command eit-dash run.

Closes #57

@wbaccinelli wbaccinelli marked this pull request as ready for review June 27, 2024 12:28
@wbaccinelli wbaccinelli requested a review from DaniBodor June 27, 2024 14:08
README.md Outdated
Comment on lines 22 to 29
The first time that the dashboard is used, the repository needs to be cloned and the package has to be
installed:

```console
git clone [email protected]:EIT-ALIVE/eit_dash.git
cd eit_dash
pip install .
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to add a note about installing in a virtual env. Especially given that the dashboard is intended for people who do not usually program, I think we should actually give the commands for creating and activating a conda env (and a link to conda for troubleshooting/installing conda in case users don't have it yet).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion!

README.md Show resolved Hide resolved
Comment on lines +38 to +40
Open the resulting link in a browser (often something like `http://127.0.0.1:8050/`).
Note that while the dashboard should work on any browser, if you are experiencing issues we recommend switching to
Chrome or Firefox, as these are the browser where we do most of the testing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment that while it's running in a browser, it is still local and not connected to the internet, and data used never goes online?

I thought we had that somewhere, but not sure where.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is in the user manual. I will add the sentence here as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that it is already here in the README.md.

@wbaccinelli wbaccinelli requested a review from DaniBodor July 4, 2024 12:05
@wbaccinelli wbaccinelli merged commit 34b3a1d into main Jul 5, 2024
2 checks passed
@wbaccinelli wbaccinelli deleted the 57_create_cli_wbaccinelli branch July 5, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create CLI for running the dashboard
2 participants