ci: Allow build action to be triggered remotely #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
DaniBodor
force-pushed
the
remote_workflow_dbodor
branch
from
31f6148 to
8b3c77a
Compare
DaniBodor
force-pushed
the
remote_workflow_dbodor
branch
5 times, most recently
from
daf501e to
524fc9a
Compare
DaniBodor
force-pushed
the
remote_workflow_dbodor
branch
7 times, most recently
from
9b2c7fc to
c2c4fbd
Compare
DaniBodor
force-pushed
the
remote_workflow_dbodor
branch
from
3e16f00 to
8407dbc
Compare
DaniBodor
force-pushed
the
remote_workflow_dbodor
branch
from
8407dbc to
ece1434
Compare
this should do the same as the build action when remotely triggered, but in a separate file for testing purposes
DaniBodor
force-pushed
the
remote_workflow_dbodor
branch
from
ece1434 to
de05e43
Compare
wbaccinelli
approved these changes
Jun 18, 2024
| @@ -41,28 +41,31 @@ jobs: | |||
| run: > | |||
| docker run | |||
| --rm | |||
| -v ${{ github.workspace }}:/ci | |||
| -v $GITHUB_WORKSPACE:/ci | |||
There was a problem hiding this comment.
What is the difference with {{ github.workspace }}?
There was a problem hiding this comment.
I think nothing (it came up when I was checking things with chatgpt), but found this slightly more readable. Wouldn't have made a separate PR for it, but while I was at it...
Comment on lines
+38
to
+42
| - name: Python info | ||
| shell: bash -e {0} | ||
| run: | | ||
| which python3 | ||
| python3 --version |
There was a problem hiding this comment.
no... it was already in there. I guess for troubleshooting reasons.
.github/workflows/lint.yml
Outdated
Comment on lines
43
to
50
| - name: Upgrade pip and install dependencies | ||
| run: | | ||
| python3 -m pip install --upgrade pip poetry | ||
| poetry install --with test | ||
| - name: Check linting and formatting using ruff | ||
| run: | | ||
| poetry run ruff check | ||
| poetry run ruff format --check |
There was a problem hiding this comment.
I wonder if it makes sense to go through poetry for checking the linting, or if we can just pip install ruff and run the check.
There was a problem hiding this comment.
I'll make the change in the other repo too :)
.github/workflows/remote_build.yml
Outdated
There was a problem hiding this comment.
It's nice to have a debug workflow ready to be used in case of need
DaniBodor
force-pushed
the
remote_workflow_dbodor
branch
5 times, most recently
from
bb9dcd9 to
4e07dd5
Compare
Lint action will bypass poetry install and always install latest version of ruff. If the action fails, a message is echoed reminding users to install the latest version of ruff. Also, poetry was updated to the newest current version of ruff.
DaniBodor
force-pushed
the
remote_workflow_dbodor
branch
from
4e07dd5 to
c339a07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the build action to be triggered by an action in a remote repo.
This will be used by eitprocessing as of PR 235, and these PRs should be reviewed together.
EDIT: @wbaccinelli , i had tagged you for review, but have since realized that it wasnt working as intended. I will fix it first and then request a new review when it's working.
--> THIS IS NOW DONE!
Some additional changes were made to the actions. All commits are atomic and can be reviewed independently.
Main additional changes: