037 implement eeli wbaccinelli

[wbaccinelli]

Implemented EELI

Fixes: #37

[DaniBodor]

How confident are we that this branch remains stable?

[DaniBodor]

I got an error when switching from a lowpass to a bandstop filter in the dropdown menu. If it's just that filter that's not working, maybe remove it for now? It doesn't stop me from proceeding though.

Traceback (most recent call last):
File "/home/dbodor/git/EIT-ALIVE/eit_dash/eit_dash/callbacks/preprocessing_callbacks.py", line 570, in enable_apply_button
and co_low > 0
TypeError: '>' not supported between instances of 'NoneType' and 'int'

[DaniBodor]

PRE-PROCESSING page

• Really nice that the preprocessing page now also has info on the selected regions in the summary section.
• The "Data filtered" box under Results is not removable and only 1 filter can be stored. I think it's overwritten when a new one is stored. It's also not associated to any data, but is just the filter itself, is that on purpose? If so, it should be called "Filter" rather than "Data filtered"

ANALYZE page

• When I click "Apply EELI", I get an empty dropdown box and no options to do anything.

Error message (when entering ANALYZE):

Traceback (most recent call last):
File "/home/dbodor/git/EIT-ALIVE/eit_dash/eit_dash/callbacks/analyze_callbacks.py", line 49, in page_setup
filter_params = period.get_data().continuous_data.data["global_impedance_filtered"].parameters
KeyError: 'global_impedance_filtered'

[wbaccinelli]

I got an error when switching from a lowpass to a bandstop filter in the dropdown menu. If it's just that filter that's not working, maybe remove it for now? It doesn't stop me from proceeding though.

Traceback (most recent call last):
File "/home/dbodor/git/EIT-ALIVE/eit_dash/eit_dash/callbacks/preprocessing_callbacks.py", line 570, in enable_apply_button
and co_low > 0
TypeError: '>' not supported between instances of 'NoneType' and 'int'

fixed here

[wbaccinelli]

PRE-PROCESSING page

• Really nice that the preprocessing page now also has info on the selected regions in the summary section.
• The "Data filtered" box under Results is not removable and only 1 filter can be stored. I think it's overwritten when a new one is stored. It's also not associated to any data, but is just the filter itself, is that on purpose? If so, it should be called "Filter" rather than "Data filtered"

Yes, this is on purpose and it filters all the periods. Only one type of filter can be applied at the moment and if a new filter is applied, it will override the previous results. I used "Data filtered", because the result is that the data have been filtered with the parameters reported, but I don't mind changing it,

ANALYZE page

• When I click "Apply EELI", I get an empty dropdown box and no options to do anything.

Error message (when entering ANALYZE):

Traceback (most recent call last):
File "/home/dbodor/git/EIT-ALIVE/eit_dash/eit_dash/callbacks/analyze_callbacks.py", line 49, in page_setup
filter_params = period.get_data().continuous_data.data["global_impedance_filtered"].parameters
KeyError: 'global_impedance_filtered'

Did you get this after applying the filter? This makes me think that I have to disable the option if no filtered data are available, or I need to use the raw data if the filtered data are not there.

[DaniBodor]

Great job!

I added 2 minor comments about the user manual. Also I noticed a typo that I made in that document at line 44, where Click is spelled with a capital and shouldn't be. Could you fix that here as well, please.

[DaniBodor]

Maybe add a note at the very top asking people to open issues if they encounter anything?