Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add formatting check to action #30

Merged
merged 2 commits into from
Mar 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,7 @@ jobs:
run: |
python3 -m pip install --upgrade pip poetry
poetry install --with test
- name: Check linting using ruff
run: poetry run ruff .
- name: Check linting and formatting using ruff
run: |
poetry run ruff check
poetry run ruff format --check
1 change: 1 addition & 0 deletions eit_dash/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
"""Documentation about eit_dash."""

import logging

logging.getLogger(__name__).addHandler(logging.NullHandler())
Expand Down
17 changes: 10 additions & 7 deletions eit_dash/utils/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,16 @@ def create_slider_figure(
if eit_variants is None:
eit_variants = ["raw"]

traces = [{
"x": dataset.eit_data[eit_variant].time,
"y": dataset.eit_data[eit_variant].global_impedance,
"type": "scatter",
"mode": "lines",
"name": "a_level",
} for eit_variant in eit_variants]
traces = [
{
"x": dataset.eit_data[eit_variant].time,
"y": dataset.eit_data[eit_variant].global_impedance,
"type": "scatter",
"mode": "lines",
"name": "a_level",
}
for eit_variant in eit_variants
]

for cont_signal in continuous_data:
traces.append( # noqa: PERF401
Expand Down
Loading