Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to new version #29

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Adapt to new version #29

merged 5 commits into from
Mar 12, 2024

Conversation

wbaccinelli
Copy link
Collaborator

Adapted the current code to the restructured code in eitprocessing

@wbaccinelli wbaccinelli requested a review from DaniBodor March 11, 2024 15:49
Copy link
Member

@DaniBodor DaniBodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently still pointing at the 181 branch of eitprocessing and the lock file was still pointing to a 3 week old version of that branch.

After updating that to the latest main, I am getting the following error when I hit confirm after pre-selecting the region I want:

Callback error updating dataset-container.children

Traceback (most recent call last):
File "/home/dbodor/git/EIT-ALIVE/eit_dash/eit_dash/callbacks/load_callbacks.py", line 189, in show_info
selected = [signals_options[s]["label"] for s in selected_signals]
TypeError: 'NoneType' object is not iterable

eitprocessing depended on a later version of ruff, so this was updated as well to avoid conflicts
@DaniBodor
Copy link
Member

Also, do you think that at this point it would be good to get the tests to work again? Or does this still depend on the tests in eitprocessing all working, because we are not quite there yet in that one :)

@wbaccinelli
Copy link
Collaborator Author

Also, do you think that at this point it would be good to get the tests to work again? Or does this still depend on the tests in eitprocessing all working, because we are not quite there yet in that one :)

At this point, it depends more on how stable the functionalities in the dashboard are (which I think is the case). So, we can start also with writing the tests. There is already an issue opened for this.

Copy link
Member

@DaniBodor DaniBodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Really happy that we finally got the main of eitprocessing in a functional state and good job making the dashboard work with that version!

@DaniBodor
Copy link
Member

These brackets were slightly off in this and/or statement. I think it probably evaluated the whole thing correctly nonetheless, but I fixed it to be sure.

@wbaccinelli wbaccinelli merged commit 6124373 into main Mar 12, 2024
1 of 2 checks passed
@wbaccinelli wbaccinelli deleted the adapt_to_new_version branch June 27, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants