-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to new version #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently still pointing at the 181 branch of eitprocessing and the lock file was still pointing to a 3 week old version of that branch.
After updating that to the latest main, I am getting the following error when I hit confirm after pre-selecting the region I want:
Callback error updating dataset-container.children
Traceback (most recent call last):
File "/home/dbodor/git/EIT-ALIVE/eit_dash/eit_dash/callbacks/load_callbacks.py", line 189, in show_info
selected = [signals_options[s]["label"] for s in selected_signals]
TypeError: 'NoneType' object is not iterable
eitprocessing depended on a later version of ruff, so this was updated as well to avoid conflicts
Also, do you think that at this point it would be good to get the tests to work again? Or does this still depend on the tests in eitprocessing all working, because we are not quite there yet in that one :) |
At this point, it depends more on how stable the functionalities in the dashboard are (which I think is the case). So, we can start also with writing the tests. There is already an issue opened for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Really happy that we finally got the main of eitprocessing in a functional state and good job making the dashboard work with that version!
These brackets were slightly off in this and/or statement. I think it probably evaluated the whole thing correctly nonetheless, but I fixed it to be sure. |
Adapted the current code to the restructured code in
eitprocessing