Ignore the picture from Microsoft OAuth data

It requires authorization to fetch, logic which we don't have yet.

Fixes #1447

modules/portal/app/auth/oauth2/providers/MicrosoftOAuth2Provider.scala

@@ -23,12 +23,13 @@ case class MicrosoftOAuth2Provider(config: play.api.Configuration) extends OAuth
         guid <- (json \ "sub").asOpt[String]
         email <- (json \ "email").asOpt[String]
         name <- (json \ "name").asOpt[String]
-        picture = (json \ "picture").asOpt[String]
+        // NB: picture is not an image URL but requires authorization to fetch further data
+        // For the time being ignore this field
       } yield UserData(
         providerId = guid,
         email = email,
         name = name,
-        imageUrl = picture
+        imageUrl = None
       )
     } catch {
       case e: JsonParseException =>

modules/portal/app/views/Helpers.scala

@@ -236,14 +236,7 @@ object Helpers {
     * Fetch a gravitar URL for the user, defaulting to the stock picture.
     */
   def gravitar(img: Option[String]): String =
-    img.map(_.replaceFirst("https?://", "//"))
-      .getOrElse(controllers.portal.routes.PortalAssets.at("img/default-gravitar.png").url)
-
-  def remoteGravitar(userId: String): String = {
-    val hash = DigestUtils.md5Hex(s"$userId@ehri-project.eu")
-    s"https://secure.gravatar.com/avatar/$hash?d=identicon"
-  }
-
+    img.getOrElse(controllers.portal.routes.PortalAssets.at("img/default-gravitar.png").url)
 
   def virtualUnitUrl(path: Seq[Model], id: String): Call = {
     if (path.isEmpty) controllers.portal.routes.VirtualUnits.browseVirtualCollection(id)