Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add myportfolio.com to yellowlist #1991

Merged
merged 1 commit into from
May 10, 2018
Merged

Add myportfolio.com to yellowlist #1991

merged 1 commit into from
May 10, 2018

Conversation

ghostwords
Copy link
Member

To unbreak Adobe Portfolio-powered sites for users logged into myportfolio.com.

Appears to be one of those cases where a website sets login/session cookies in the first-party context while also serving static resources in third-party contexts using domains that receive the previously set login cookies.

Error report counts by page domain and exact blocked subdomain:

+------------------------------+-------------------------------------+-------+
| fqdn                         | blocked_fqdn                        | count |
+------------------------------+-------------------------------------+-------+
| adrenaline.de                | pro2-bar-s3-cdn-cf.myportfolio.com  |     1 |
| amstudio.rocks               | pro2-bar-s3-cdn-cf.myportfolio.com  |     1 |
| claudiahaon.com              | pro2-bar-s3-cdn-cf.myportfolio.com  |     1 |
| dantaylr.com                 | pro2-bar-s3-cdn-cf.myportfolio.com  |     1 |
| jeffreyphillips.com.au       | pro2-bar-s3-cdn-cf.myportfolio.com  |     1 |
| joenisbett.com               | pro2-bar-s3-cdn-cf.myportfolio.com  |     1 |
| krisblackmore.com            | pro2-bar-s3-cdn-cf.myportfolio.com  |     1 |
| nickliphotos.com             | pro2-bar-s3-cdn-cf.myportfolio.com  |     1 |
| robertsrurans.com            | pro2-bar-s3-cdn-cf.myportfolio.com  |     1 |
...

Error report counts by date and exact blocked subdomain:

+---------+-------------------------------------+-------+
| ym      | blocked_fqdn                        | count |
+---------+-------------------------------------+-------+
| 2018-04 | pro2-bar-s3-cdn-cf.myportfolio.com  |     1 |
| 2018-04 | pro2-bar-s3-cdn-cf1.myportfolio.com |     1 |
| 2018-04 | pro2-bar-s3-cdn-cf2.myportfolio.com |     1 |
| 2018-04 | pro2-bar-s3-cdn-cf3.myportfolio.com |     1 |
| 2018-04 | pro2-bar-s3-cdn-cf4.myportfolio.com |     1 |
| 2018-04 | pro2-bar-s3-cdn-cf5.myportfolio.com |     1 |
| 2018-04 | pro2-bar-s3-cdn-cf6.myportfolio.com |     1 |
| 2018-03 | pro2-bar-s3-cdn-cf.myportfolio.com  |     4 |
| 2018-03 | pro2-bar-s3-cdn-cf1.myportfolio.com |     3 |
| 2018-03 | pro2-bar-s3-cdn-cf2.myportfolio.com |     4 |
| 2018-03 | pro2-bar-s3-cdn-cf3.myportfolio.com |     3 |
| 2018-03 | pro2-bar-s3-cdn-cf4.myportfolio.com |     3 |
| 2018-03 | pro2-bar-s3-cdn-cf5.myportfolio.com |     3 |
| 2018-03 | pro2-bar-s3-cdn-cf6.myportfolio.com |     4 |
| 2018-02 | pro2-bar-s3-cdn-cf1.myportfolio.com |     1 |
| 2018-02 | pro2-bar-s3-cdn-cf2.myportfolio.com |     1 |
| 2018-02 | pro2-bar-s3-cdn-cf4.myportfolio.com |     1 |
| 2018-02 | pro2-bar-s3-cdn-cf6.myportfolio.com |     1 |
...

@ghostwords
Add myportfolio.com to yellowlist.
572f50a 
To unbreak Adobe Portfolio-powered sites for users logged into
myportfolio.com
@ghostwords ghostwords added the yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage label Apr 26, 2018
@ghostwords ghostwords requested a review from bcyphers April 26, 2018 14:48
@ghostwords
Copy link
Member Author

Previously: #1922.

Probably related: #1545 (comment).

@ghostwords ghostwords added the login cookies A sub-category of "broken site" issues; might be common enough for us to try to work around entirely label Apr 28, 2018
bcyphers
bcyphers approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@bcyphers bcyphers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ghostwords ghostwords merged commit 572f50a into master May 10, 2018
ghostwords added a commit that referenced this pull request May 10, 2018
@ghostwords
Merge pull request #1991.
c6da8f4 
Add myportfolio.com to yellowlist.
@ghostwords ghostwords deleted the yellowlist-myportfolio.com branch May 10, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcyphers bcyphers bcyphers approved these changes

Assignees
No one assigned
Labels
login cookies A sub-category of "broken site" issues; might be common enough for us to try to work around entirely yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostwords @bcyphers