Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: [tests] Create test foundations #64

Merged
merged 94 commits into from
Jun 19, 2024
Merged

new: [tests] Create test foundations #64

merged 94 commits into from
Jun 19, 2024

Conversation

cvandeplas
Copy link
Contributor

@cvandeplas cvandeplas commented Apr 25, 2024

  • foundations of tests for ubuntu + mac testing
  • find/generate test data that can be published publicly - as git submodule
  • allow private test data in testdata-private folder
  • parser - basic tests
  • unify parser main function and params
  • adapt parsing.py and initialise.py to new function call
  • adapt analysers to new data format
  • analysers - basic tests (for later ... or not)

@cvandeplas cvandeplas self-assigned this Apr 25, 2024
@cvandeplas cvandeplas marked this pull request as draft April 25, 2024 13:42
@cvandeplas cvandeplas changed the title new: [tests] Create pytest.yml new: [tests] Create test foundations Apr 26, 2024
@cvandeplas
Copy link
Contributor Author

Meant to also address issues #40 , #41

@aaronkaplan
Copy link
Contributor

I can check out the repo and test on a Mac.

@cvandeplas
Copy link
Contributor Author

No worries @aaronkaplan , I now also have a mac at my disposal.

@aaronkaplan
Copy link
Contributor

excellent

@cvandeplas
Copy link
Contributor Author

Last test broke on MacOS:

  File "/Users/runner/work/sysdiagnose/sysdiagnose/analysers/apps.py", line 86, in analyse_path
    for entry in ijson.items(f, 'data.item'):
ijson.common.IncompleteJSONError: parse error: trailing garbage
          parentActivityIdentifier":0} {"timezoneName":"","eventType":
                     (right here) ------^

@cvandeplas
Copy link
Contributor Author

Linux test will break until PR mandiant/macos-UnifiedLogs#18 is merged.

@cvandeplas
Copy link
Contributor Author

wooohoo, tests are now fine as unifiedlog_parser_json patch has been accepted !

@cvandeplas cvandeplas marked this pull request as ready for review June 19, 2024 07:11
@cvandeplas cvandeplas merged commit 991bff3 into main Jun 19, 2024
5 checks passed
cvandeplas added a commit that referenced this pull request Jun 20, 2024
new: [tests] Create test foundations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants