Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAM4xx: Add reader for season_wes, which is part of the microphysics interface. #3108

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

odiazib
Copy link
Contributor

@odiazib odiazib commented Nov 13, 2024

We use the scream_scorpio interface to read the variable season_wes from the NC file:

${DIN_LOC_ROOT}/atm/scream/mam4xx/drydep/season_wes.nc

netcdf season_wes {
dimensions:
    lat = 360 ;
    pft = 11 ;
    time = UNLIMITED ; // (12 currently)
variables:
    float lat(lat) ;
        lat:long_name = " " ;
        lat:units = " " ;
    int season_wes(time, pft, lat) ;
        season_wes:long_name = " " ;
        season_wes:units = " " ;
}

The variable season_wes along with latitude from the host model is used to compute index_season_lai.

We have ported the block of code to compute index_season_lai in the mam4xx routine find_season_index. see PR 361

Copy link
Contributor

mergify bot commented Nov 13, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟠 Enforce checks passing

Waiting checks: gcc-cuda / ${{ matrix.build_type }}, gcc-cuda / dbg, gcc-cuda / opt, gcc-cuda / sp, gcc-openmp / ${{ matrix.build_type }}, gcc-openmp / dbg, gcc-openmp / opt, gcc-openmp / sp.

Make sure that checks are not failing on the PR, and reviewers approved

  • any of:
    • check-skipped={% raw %}gcc-openmp / ${{ matrix.build_type }}{% endraw %}
    • all of:
      • check-success="gcc-openmp / dbg"
      • check-success="gcc-openmp / opt"
      • check-success="gcc-openmp / sp"
      • check-success="gcc-openmp / fpe"
  • any of:
    • check-skipped={% raw %}gcc-cuda / ${{ matrix.build_type }}{% endraw %}
    • all of:
      • check-success="gcc-cuda / dbg"
      • check-success="gcc-cuda / opt"
      • check-success="gcc-cuda / sp"
  • #approved-reviews-by >= 1
  • #changes-requested-reviews-by == 0
  • any of:
    • all of:
      • check-success="cpu-gcc / ERS_Ln22.ne4pg2_ne4pg2.F2010-SCREAMv1.scream-small_kernels--scream-output-preset-5"
      • check-success="cpu-gcc / ERS_Ln9.ne4_ne4.F2000-SCREAMv1-AQP1.scream-output-preset-2"
      • check-success="cpu-gcc / ERS_P16_Ln22.ne30pg2_ne30pg2.FIOP-SCREAMv1-DP.scream-dpxx-arm97"
      • check-success="cpu-gcc / SMS_D_Ln5.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.scream-mam4xx-all_mam4xx_procs"
    • check-skipped={% raw %}cpu-gcc / ${{ matrix.test.short_name }}{% endraw %}
  • any of:
    • check-skipped=cpu-gcc
    • check-success=cpu-gcc

singhbalwinder
singhbalwinder previously approved these changes Nov 13, 2024
Copy link
Contributor

@singhbalwinder singhbalwinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left very minor comments. Overall looks great!

@odiazib odiazib force-pushed the oscar/find_season_index branch from 46cc455 to 9fbdbb3 Compare November 14, 2024 17:05
@odiazib odiazib requested a review from mahf708 November 15, 2024 16:44
@jgfouca jgfouca merged commit 37dea04 into E3SM-Project:master Nov 15, 2024
13 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants