-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAM4xx: Add reader for season_wes, which is part of the microphysics interface. #3108
Merged
jgfouca
merged 6 commits into
E3SM-Project:master
from
eagles-project:oscar/find_season_index
Nov 15, 2024
Merged
MAM4xx: Add reader for season_wes, which is part of the microphysics interface. #3108
jgfouca
merged 6 commits into
E3SM-Project:master
from
eagles-project:oscar/find_season_index
Nov 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟠 Enforce checks passingWaiting checks:
|
singhbalwinder
previously approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left very minor comments. Overall looks great!
components/eamxx/src/physics/mam/readfiles/find_season_index_utils.hpp
Outdated
Show resolved
Hide resolved
components/eamxx/src/physics/mam/readfiles/find_season_index_utils.hpp
Outdated
Show resolved
Hide resolved
odiazib
force-pushed
the
oscar/find_season_index
branch
from
November 14, 2024 17:05
46cc455
to
9fbdbb3
Compare
bartgol
approved these changes
Nov 15, 2024
mahf708
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the
scream_scorpio
interface to read the variableseason_wes
from the NC file:${DIN_LOC_ROOT}/atm/scream/mam4xx/drydep/season_wes.nc
The variable
season_wes
along with latitude from the host model is used to compute index_season_lai.We have ported the block of code to compute
index_season_lai
in the mam4xx routinefind_season_index
. see PR 361