-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Interface and Validation Testing for MAM4xx Online Emissions #3083
Conversation
|
Thanks, @mjs271 ! Reviewers: I will let you know when it is ready for review. We need to run some more tests, which might bring in more changes. |
Tagging @susburrows. |
config_.amicphys.nucleation.pbl_nuc_wang2008_user_choice = 1; | ||
config_.amicphys.nucleation.adjust_factor_pbl_ratenucl = 1.0; | ||
config_.amicphys.nucleation.accom_coef_h2so4 = 1.0; | ||
//config_.amicphys.nucleation.dens_so4a_host = 1770.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These mods are due to the mismatch in the mam4xx submodule. Once microphysics PR is merged, we will rebase to remove these mods.
aircon, num_gas_ids, qgas_cur, qgas_avg, qgas_netprod_otrproc, | ||
qaer_cur, qnum_cur, dgn_awet, alnsg_aer, uptk_rate_factor, uptkaer, | ||
uptkrate_h2so4, niter_out, g0_soa_out); | ||
// gasaerexch::mam_gasaerexch_1subarea( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These mods are due to the mismatch in the mam4xx submodule. Once microphysics PR is merged, we will rebase to remove these mods.
Removed WIP to get it tested once. I will WIP it again after the testing. |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: mjs271 |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Weaver # 6268 FAILED (click to see last 100 lines of console output)
|
Looks like the model failed to download a data file:
This file is present on the server at:https://web.lcrc.anl.gov/public/e3sm/inputdata/atm/scream/mam4xx/emissions/ne2np4/ I am not sure why the model can't download it. |
Stranger yet, the file appears to be on weaver already
|
There was a PR that went in recently: #3080 (luca may have something to say) |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: mjs271 |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Weaver # 6270 FAILED (click to see last 100 lines of console output)
|
This reverts commit 22086f1.
d7cadd7
to
c8c4d65
Compare
@mahf708 : Thanks again for the review. We have addressed all the comments except for the file reading (as we will revisit it later). I will create an issue for the other comment about using the scaling function. @mjs271 have tested on PM-GPUs and these codes are not generating any new warnings. This should be ready to merge now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
An existing EAMxx interface (
eamxx_mam_srf_and_online_emissions_process_interface.cpp
) is modified to include the invocation of the "online" emissions of dust and sea salt. The new additions are for:Since the CMake option,
SCREAM_ENABLE_MAM
, is alwaysON
, these codes are always compiled with the EAMxx codebase, but this interface can be turned off/on using the namelist flags.Output variables
The output variable names are "constituent_fluxes" and interstitial aerosols whose emissions are computed:
nacl_a1
,mom_a1
,num_a1
,nacl_a2
,mom_a2
,num_a2
,dust_a3
,nacl_a3
,mom_a3
,num_a3
,mom_a4
,num_a4
Note that the "constituent_fluxes" indices are exactly the same as EAM's
state%q
.Testing
We have existing tests for this interface, so we didn't add any new tests. We have a suite of validation tests in the MAM4xx repo to validate the online emission processes.
The
srf_online_emiss
process that invokes online emissions codes has to be invoked with theconstituent_fluxes
process to modify interstitial aerosols. Otherwise, only theconstituent_fluxes
array will be modified. These processes are added as an EAMxx process with the ability to turn it on/off using the labelsmam4_srf_online_emiss
andmam4xx-constituent_fluxes
in thenamelist_scream.xml
file. Theatmchange
command to invoke these processes in a CIME simulation is:To run a CIME simulation, we have created a test modifier
mam4xx-srf_online_emiss_constituent_fluxes
:Where,
<machine>
is the machine name<compiler>
is the compiler to use on the machine<test id>
is a unique string test identifier<project id>
is the allocation project to chargeNew input data
We have added 6 files for each of the three grid resolutions:
ne2np4
,ne4pg2
,ne30pg2
for soil erodibility (3 files) and marine organic aerosols (3 files)
For finer resolutions, the code will interpolate the
ne30pg2
grid. All the files are on the E3SM input data server.Figures from model analysis
Aerosol burdens from surface emissions only simulation at ne30pg2 resolution. We have added prescribed emissions plots to show that they remain unchanged (plots generated by Meng):
NOTE: There is an initial unphysical spike in dust burden when we use ne4 resolution. @kaizhangpnl found that that the spike may be due to the huge jump in mean u10 velocity between 1st and 2nd time step (see his comments below). Here are plots from ne4 simulation (generated by Chandru)
Standalone Test Timings (Compy):
We will upload the timings once the PR is reviewed and approved