Fix valgrind errors in eamxx_homme_iop.cpp #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were running off the end of a couple views.
jgfouca
commented
Jun 4, 2024
| Mask nudge_level; | ||
| for (int p=0; p<Pack::n; ++p) { | ||
| const auto lev = k*Pack::n + p; | ||
| Mask nudge_level(false); |
There was a problem hiding this comment.
I assume I should default this mask to all false?
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: jgfouca |
AaronDonahue
approved these changes
Jun 4, 2024
jgfouca
commented
Jun 4, 2024
| const auto lev = k*Pack::n + p; | ||
| Mask nudge_level(false); | ||
| int max_size = hyam.size(); | ||
| for (int lev=k*Pack::n, p = 0; p < Pack::n && lev < max_size; ++lev, ++p) { | ||
| const auto pressure_from_iop = hyam(lev)*ps0 + hybm(lev)*ps_iop; | ||
| nudge_level.set(p, pressure_from_iop <= iop_nudge_tq_low*100 |
There was a problem hiding this comment.
@bogensch , this looks like a bug. How can pressure ever be both low and high? This and should be an or I think.
There was a problem hiding this comment.
It's not a bug, just confusing names..... Valid example values: iop_nudge_tq_low = 1000 hPa; iop_nudge_tq_high=700 hPa. Thus low/high refers to the relative position in the atmosphere with respect to the surface rather than the value.
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running off the end of a couple views.
Example from my debugging printing:
JGF lev=79 hyam.size=72, hybm.size=72