Apply suggestions from code review

Co-authored-by: Luca Bertagna <[email protected]>
E3SM-Project · May 16, 2024 · 2a2b5e9 · 2a2b5e9
1 parent 93ef4a4
commit 2a2b5e9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/components/eamxx/src/diagnostics/pbl_entrainment_budget.cpp b/components/eamxx/src/diagnostics/pbl_entrainment_budget.cpp
@@ -119,7 +119,7 @@ void PBLEntrainmentBudget::calc_tl_qt(const view_2d &tm_v, const view_2d &pm_v,
   int nlevs = m_nlevs;
   Kokkos::parallel_for(
       Kokkos::RangePolicy<>(0, ncols * nlevs), KOKKOS_LAMBDA(const int &idx) {
-        const int icol   = idx / ncols;
+        const int icol   = idx / nlevs;
         const int jlev   = idx % nlevs;
         qt_v(icol, jlev) = qc_v(icol, jlev) + qv_v(icol, jlev);
         tl_v(icol, jlev) = PF::calculate_thetal_from_theta(

diff --git a/components/eamxx/src/diagnostics/tests/pbl_entrainment_budget_test.cpp b/components/eamxx/src/diagnostics/tests/pbl_entrainment_budget_test.cpp
@@ -121,7 +121,6 @@ TEST_CASE("entrainment_budget") {
 
   constexpr int ntests = 1;
   for(int itest = 0; itest < ntests; ++itest) {
-    // {
     // Randomize
     randomize(qc, engine, pdf);
     randomize(qv, engine, pdf);