Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to mosaic for all plotting functionality #256

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrewdnolan
Copy link

@andrewdnolan andrewdnolan commented Dec 24, 2024

Partially fixes #255 and fixes the plotting issues from #242.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes

- Interface to the `plot_horiz_field` has been simplified slightly.

- The mask array now must be the same shape as the input field array.

- Added a framework function to convert a cell mask to and edge mask.
Also simplified the config options for the colorbar options, which
makes the spherical and lat/lon plots have the same options
@xylar
Copy link
Collaborator

xylar commented Dec 25, 2024

@andrewdnolan, could you change "Fixes #255" to "Partially addresses #255" since we don't want to add python 3.13 testing in this PR. If you leave things as they are, merging this PR will automatically close #255.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to add support for python 3.13
2 participants