Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 0.4.0-alpha.1 #204

Merged
merged 9 commits into from
Jul 23, 2024
Merged

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jul 17, 2024

Deployed and Tested

MPAS-Ocean with pr:

Omega CTests:

@xylar xylar added deployment Changes relate to creating conda and Spack environments, and creating a load script E3SM PR finished The polaris changes required an update to the E3SM-Project submodule and this is now finished Omega PR finished The polaris changes required an update to the Omega submodule and this is now finished in progress This PR is not ready for review or merging labels Jul 17, 2024
@xylar xylar self-assigned this Jul 17, 2024
@xylar xylar force-pushed the update-to-0.4.0-alpha.1 branch from b448516 to b26d117 Compare July 18, 2024 18:42
@xylar xylar removed the in progress This PR is not ready for review or merging label Jul 18, 2024
@xylar xylar marked this pull request as ready for review July 18, 2024 18:43
@xylar xylar force-pushed the update-to-0.4.0-alpha.1 branch from b26d117 to 1cdd67f Compare July 18, 2024 20:22
@xylar xylar requested a review from altheaden July 18, 2024 20:40
@xylar xylar force-pushed the update-to-0.4.0-alpha.1 branch from 07eb48a to 52e84b7 Compare July 23, 2024 08:36
xylar added 2 commits July 23, 2024 02:55
This requires a debug reservation as well, which polaris doesn't
support.
@xylar
Copy link
Collaborator Author

xylar commented Jul 23, 2024

@altheaden, I need to test Chrysalis one more time to make sure the patched mache does what it should. Then, I think this is ready to merge. Could you approve based on your testing?

@altheaden
Copy link
Collaborator

@xylar could any of the most recent changes you've made have affected the testing I did on pm-cpu and pm-gpu? I don't think so, but let me know if you want me to re-test any of those. Assuming we don't need to re-test, I'll go ahead and mark this as ready to merge based on my testing.

@xylar
Copy link
Collaborator Author

xylar commented Jul 23, 2024

@altheaden, I don't think my recent changes will have any effect on Perlmutter so I think your test results are fine as they are. There would be no problem with you running them again if you want to but I don't think it's necessary. Thanks for checking on that, though.

Copy link
Collaborator

@altheaden altheaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me then.

@xylar
Copy link
Collaborator Author

xylar commented Jul 23, 2024

Running one last Chrysalis gnu test, then I will merge!!!

@xylar xylar merged commit d468fbd into E3SM-Project:main Jul 23, 2024
4 checks passed
@xylar xylar deleted the update-to-0.4.0-alpha.1 branch July 23, 2024 20:42
@xylar xylar mentioned this pull request Nov 13, 2024
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Changes relate to creating conda and Spack environments, and creating a load script E3SM PR finished The polaris changes required an update to the E3SM-Project submodule and this is now finished Omega PR finished The polaris changes required an update to the Omega submodule and this is now finished
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants