Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only print task baseline status if basline compared #133

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Only print task baseline status if basline compared #133

merged 1 commit into from
Oct 10, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Oct 9, 2023 •
edited
Loading

Before this merge, we were incorrectly printing a message that baselines passed when no baseline comparison was made. With this fix, a message about baselines is only printed if baseline comparisons were performed.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

closes #132

@xylar xylar added bug Something isn't working framework Changes relating to the polaris framework as opposed to individual tests or analysis in progress This PR is not ready for review or merging labels Oct 9, 2023
@xylar
Only print task baseline status if basline compared
6e67627 
Before this merge, we were incorrectly printing a message that
baselines passed when no baseline comparison was made.  With this
fix, a message about baselines is only printed if baseline
comparisons were performed.
@xylar xylar force-pushed the fix-task-baseline branch from ac17a90 to 6e67627 Compare October 10, 2023 07:27
@xylar xylar removed the in progress This PR is not ready for review or merging label Oct 10, 2023
@xylar xylar marked this pull request as ready for review October 10, 2023 07:32
@xylar
Copy link
Collaborator Author

xylar commented Oct 10, 2023

Testing

I ran the inertial_gravity_wave test (without a baseline) on Chrysalis and now see:

ocean/planar/inertial_gravity_wave
  * step: init_200km
          execution:        SUCCESS
          runtime:          0:00:02
  * step: forward_200km
          execution:        SUCCESS
          runtime:          0:00:03
  * step: init_100km
          execution:        SUCCESS
          runtime:          0:00:01
  * step: forward_100km
          execution:        SUCCESS
          runtime:          0:00:07
  * step: init_50km
          execution:        SUCCESS
          runtime:          0:00:02
  * step: forward_50km
          execution:        SUCCESS
          runtime:          0:00:16
  * step: init_25km
          execution:        SUCCESS
          runtime:          0:00:07
  * step: forward_25km
          execution:        SUCCESS
          runtime:          0:00:22
  * step: analysis
          execution:        SUCCESS
          runtime:          0:00:00
  task execution:   SUCCESS
  task runtime:     0:01:01
Task Runtimes:
0:01:01 PASS ocean/planar/inertial_gravity_wave
Total runtime: 0:01:01
PASS: All passed successfully!

When I run with a baseline, I see:

ocean/planar/inertial_gravity_wave
  * step: init_200km
          execution:        SUCCESS
          runtime:          0:00:03
  * step: forward_200km
          execution:        SUCCESS
          baseline comp.:   PASS
          runtime:          0:00:03
  * step: init_100km
          execution:        SUCCESS
          runtime:          0:00:01
  * step: forward_100km
          execution:        SUCCESS
          baseline comp.:   PASS
          runtime:          0:00:07
  * step: init_50km
          execution:        SUCCESS
          runtime:          0:00:02
  * step: forward_50km
          execution:        SUCCESS
          baseline comp.:   PASS
          runtime:          0:00:17
  * step: init_25km
          execution:        SUCCESS
          runtime:          0:00:07
  * step: forward_25km
          execution:        SUCCESS
          baseline comp.:   PASS
          runtime:          0:00:22
  * step: analysis
          execution:        SUCCESS
          runtime:          0:00:00
  task execution:   SUCCESS
  baseline comp.:   PASS
  task runtime:     0:01:04
Task Runtimes:
0:01:04 PASS ocean/planar/inertial_gravity_wave
Total runtime: 0:01:05
PASS: All passed successfully

@xylar xylar self-assigned this Oct 10, 2023
@xylar xylar merged commit 2ddd30f into E3SM-Project:main Oct 10, 2023
5 checks passed
@xylar xylar deleted the fix-task-baseline branch October 10, 2023 10:06
@cbegeman
Copy link
Collaborator

@xylar Thanks for making this fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
bug Something isn't working framework Changes relating to the polaris framework as opposed to individual tests or analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Baseline comparison "passes" when baseline absent
2 participants
@xylar @cbegeman