Updates for pyremap >= 1.1.0 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merge switches to only using SCRIP, not ESMF, format in anticipation of adding `mbtempest` support. Some bugs in projection and point descriptor support have also been fixed.
TestingThe cosine bell tests with viz (the only tests that use the remapping capability at the moment) run fine with these changes. |
xylar
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make a few changes to remapping to take advantage of pyremap 1.1.0 and later. This merge switches to only using SCRIP, not ESMF, format in anticipation of adding
mbtempestsupport. It uses the new mesh descriptors for cell and vertex meshes.Some bugs in projection and point descriptor support have also been fixed.
Checklist
Testingcomment in the PR documents testing used to verify the changes