Clean up RPE analysis step and framework #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the place where nu is added to model config options.
TestingI successfully ran the 10 km RPE test on Chrysalis. The updated output is: For reference, old output from #27 was: |
|
@cbegeman, a quick review by inspection would be appreciated. It might be nice to add the ability to share y labels and have a single colorbar like in the original plot, but that isn't a high priority for me right now. |
xylar
commented
Sep 27, 2023
Comment on lines
+38
to
+40
| xEdge = ds_mesh.xEdge | ||
| yEdge = ds_mesh.yEdge | ||
| areaCell = ds_mesh.areaCell |
There was a problem hiding this comment.
This change is in the spirit of not assuming that mesh variables are in the initial condition.
xylar
added
bug
cbegeman
approved these changes
Sep 27, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using some iffy custom plotting techniques, this uses the framework
plot_horiz_field()function.This merge also fix a bug in the placement of
nubeing added to model config options. Before this fix, theforward.yamloptions were overwriting thenuvalue so all RPE runs used the same viscosity. This problem was introduced in the initial port of baroclinic channel (875e7fe) but apparently after initial testing showed that it worked as expected.Checklist
Testingcomment in the PR documents testing used to verify the changes