Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to mpas_tools v0.23.0 #121

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Sep 25, 2023

The newer MPAS-Tools brings in the new, faster version of the MPAS mesh converter and cell culler, as well as tools for sorting mesh indices for improved MPAS-Ocean parallel and memory performance.

This merge also ports over a small change from MPAS-Dev/compass#659 to better support large spherical meshes.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@xylar xylar added clean-up deployment Changes relate to creating conda and Spack environments, and creating a load script ocean Related to ocean tests or analysis labels Sep 25, 2023
@xylar xylar self-assigned this Sep 25, 2023
This brings in the new version of the MPAS mesh converter and
cell culler, as well as tools for sorting mesh indices for
improved efficiency
This is better for large meshes than using the wrapper function,
since it avoids reading the mesh in to memory with xarray.
@xylar xylar force-pushed the update-to-mpas-tools-0.23.0 branch from 2368def to e9870cf Compare September 25, 2023 14:16
@xylar xylar force-pushed the update-to-mpas-tools-0.23.0 branch from cad0a38 to 6bf7010 Compare September 25, 2023 15:05
@xylar
Copy link
Collaborator Author

xylar commented Sep 25, 2023

Testing

The pr and cosine_bell test suites produce BFB identical results with a baseline from main with this branch, running on Chrysalis with Intel and OpenMPI.

@xylar
Copy link
Collaborator Author

xylar commented Sep 25, 2023

@cbegeman, just a heads up that I'm merging this. I think my testing is sufficient and no review is needed. It shouldn't affect most work but it feels worth having for ISOMIP+ work I started on today.

@xylar xylar merged commit e9ed211 into E3SM-Project:main Sep 25, 2023
@xylar xylar deleted the update-to-mpas-tools-0.23.0 branch September 25, 2023 15:20
@xylar xylar mentioned this pull request Sep 28, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up deployment Changes relate to creating conda and Spack environments, and creating a load script ocean Related to ocean tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant