Skip to content

Commit

Permalink
Merge pull request #214 from xylar/fix-linux
Browse files Browse the repository at this point in the history
Fix deployment on unknown machines
  • Loading branch information
xylar authored Aug 1, 2024
2 parents 387f105 + 17f88f4 commit ce915e6
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 13 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/build_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,15 @@ jobs:
run: |
git config --global url."https://github.com/".insteadOf "[email protected]:"
./configure_polaris_envs.py \
--conda_env_only \
--env_name polaris_test \
--verbose \
--python=${{ matrix.python-version }}
source load_polaris_test.sh
source load_polaris_test_mpich.sh
- if: ${{ steps.skip_check.outputs.should_skip != 'true' }}
name: Build Sphinx Docs
run: |
source load_polaris_test.sh
source load_polaris_test_mpich.sh
# sphinx-multiversion expects at least a "main" branch
git branch main || echo "branch main already exists."
cd docs
Expand Down
14 changes: 8 additions & 6 deletions deploy/bootstrap.py
Original file line number Diff line number Diff line change
Expand Up @@ -373,13 +373,14 @@ def build_jigsaw(activate_env, conda_base, source_path, env_path, logger):

print('Building JIGSAW\n')
# add build tools to deployment env, not polaris env
jigsaw_build_deps = 'cxx-compiler cmake'
jigsaw_build_deps = 'cxx-compiler cmake make'
if platform.system() == 'Linux':
jigsaw_build_deps = f'{jigsaw_build_deps} sysroot_linux-64=2.17'
netcdf_lib = f'{env_path}/lib/libnetcdf.so'
elif platform.system() == 'Darwin':
jigsaw_build_deps = \
f'{jigsaw_build_deps} macosx_deployment_target=10.13'
netcdf_lib = f'{env_path}/lib/libnetcdf.so'
f'{jigsaw_build_deps} macosx_deployment_target_osx-64=10.13'
netcdf_lib = f'{env_path}/lib/libnetcdf.dylib'
cmake_args = f'-DCMAKE_BUILD_TYPE=Release -DNETCDF_LIBRARY={netcdf_lib}'

commands = \
Expand Down Expand Up @@ -1192,12 +1193,13 @@ def main(): # noqa: C901
f'export PIO={conda_env_path}\n' \
f'export OPENMP_INCLUDE=-I"{conda_env_path}/include"\n'

if soft_spack_view is None:
if soft_spack_view is not None:
env_vars = f'{env_vars}' \
f'export PATH="{soft_spack_view}/bin:$PATH"\n'
elif known_machine:
raise ValueError('A software compiler or a spack base was not '
'defined so required software was not '
'installed with spack.')
env_vars = f'{env_vars}' \
f'export PATH="{soft_spack_view}/bin:$PATH"\n'

else:
env_vars = ''
Expand Down
6 changes: 3 additions & 3 deletions deploy/default.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ geometric_features = 1.2.0
mache = 1.24.0
mpas_tools = 0.34.1
otps = 2021.10
parallelio = 2.6.0
parallelio = 2.6.2

# versions of conda or spack packages (depending on machine type)
esmf = 8.4.2
esmf = 8.6.1
metis = 5.1.0
moab = 5.5.1
netcdf_c = 4.9.2
netcdf_fortran = 4.6.1
pnetcdf = 1.12.3
pnetcdf = 1.13.0

# versions of spack packages
albany = develop
Expand Down
2 changes: 1 addition & 1 deletion polaris/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '0.4.0-alpha.1'
__version__ = '0.4.0-alpha.2'

0 comments on commit ce915e6

Please sign in to comment.