Remove convergence plot from viz steps

E3SM-Project · Oct 9, 2023 · c5a60df · c5a60df
1 parent 85d4d1e
commit c5a60df
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 44 deletions.
diff --git a/polaris/ocean/tasks/inertial_gravity_wave/viz.py b/polaris/ocean/tasks/inertial_gravity_wave/viz.py
@@ -53,7 +53,6 @@ def __init__(self, component, resolutions, taskdir):
                 filename=f'output_{mesh_name}.nc',
                 target=f'../forward/{mesh_name}/output.nc')
 
-        self.add_output_file('convergence.png')
         self.add_output_file('comparison.png')
 
     def run(self):
@@ -117,24 +116,3 @@ def run(self):
                         size='large', ha='right', va='center')
 
         fig.savefig('comparison.png', bbox_inches='tight', pad_inches=0.1)
-
-        # Convergence plots
-        fig = plt.figure()
-        ax = fig.add_subplot(111)
-        p = np.polyfit(np.log10(resolutions), np.log10(rmse), 1)
-        conv = np.round(p[0], 3)
-        ax.loglog(resolutions, rmse, '-ok', label=f'numerical (order={conv})')
-
-        c = rmse[0] * 1.5 / resolutions[0]
-        order1 = c * np.power(resolutions, 1)
-        c = rmse[0] * 1.5 / resolutions[0]**2
-        order2 = c * np.power(resolutions, 2)
-
-        ax.loglog(resolutions, order1, '--k', label='first order', alpha=0.3)
-        ax.loglog(resolutions, order2, 'k', label='second order', alpha=0.3)
-        ax.set_xlabel('resolution (km)')
-        ax.set_ylabel('RMS error (m)')
-        ax.invert_xaxis()
-        ax.set_title('Error Convergence')
-        ax.legend(loc='lower left')
-        fig.savefig('convergence.png', bbox_inches='tight', pad_inches=0.1)
diff --git a/polaris/ocean/tasks/manufactured_solution/viz.py b/polaris/ocean/tasks/manufactured_solution/viz.py
@@ -53,7 +53,7 @@ def __init__(self, component, resolutions, taskdir):
                 filename=f'output_{mesh_name}.nc',
                 target=f'../forward/{mesh_name}/output.nc')
 
-        self.add_output_file('convergence.png')
+        self.add_output_file('comparison.png')
 
     def run(self):
         """
@@ -114,24 +114,3 @@ def run(self):
                         size='large', ha='right', va='center')
 
         fig.savefig('comparison.png', bbox_inches='tight', pad_inches=0.1)
-
-        # Convergence polts
-        fig = plt.figure()
-        ax = fig.add_subplot(111)
-        p = np.polyfit(np.log10(resolutions), np.log10(rmse), 1)
-        conv = np.round(p[0], 3)
-        ax.loglog(resolutions, rmse, '-ok', label=f'numerical (order={conv})')
-
-        c = rmse[0] * 1.5 / resolutions[0]
-        order1 = c * np.power(resolutions, 1)
-        c = rmse[0] * 1.5 / resolutions[0]**2
-        order2 = c * np.power(resolutions, 2)
-
-        ax.loglog(resolutions, order1, '--k', label='first order', alpha=0.3)
-        ax.loglog(resolutions, order2, 'k', label='second order', alpha=0.3)
-        ax.set_xlabel('resolution (km)')
-        ax.set_ylabel('RMS error (m)')
-        ax.set_title('Error Convergence')
-        ax.invert_xaxis()
-        ax.legend(loc='lower left')
-        fig.savefig('convergence.png', bbox_inches='tight', pad_inches=0.1)