Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to 3.0.0rc1 #910

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Bump to 3.0.0rc1 #910

merged 3 commits into from
Jan 17, 2025

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Jan 10, 2025 •
edited
Loading

Description

PRs to merge before this PR

Summary of Changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder self-assigned this Jan 15, 2025
@tomvothecoder tomvothecoder added the update version Code specifically to update the version label Jan 15, 2025
@tomvothecoder tomvothecoder marked this pull request as ready for review January 16, 2025 22:48
@tomvothecoder tomvothecoder mentioned this pull request Jan 16, 2025
Merged
9 tasks
@tomvothecoder
Remove esmpy dependency
4639969 
- Remove `import shapely` since `esmpy` and `cdms2` are no longer direct dependencies
tomvothecoder
tomvothecoder commented Jan 16, 2025
View reviewed changes
e3sm_diags/__init__.py
Comment on lines -4 to -7
# import shapely here (before any esmpy imports via cdms2) to prevent a
# segfault related to multiprocessing. Do not import esmpy here to prevent
# issue with dask when using ESMF with system compilers.
import shapely
Copy link
Collaborator Author

@tomvothecoder tomvothecoder Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @xylar I don't think this is needed anymore because cdms2 and esmpy are no longer direct dependencies. Correct me if I'm wrong though. This is related to #715.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable.

tomvothecoder
tomvothecoder commented Jan 16, 2025
View reviewed changes
Copy link
Collaborator Author

@tomvothecoder tomvothecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xylar, a quick review of the dependency change would be great. Almost done with v3.0.0rc1!

@tomvothecoder tomvothecoder requested a review from xylar January 17, 2025 00:07
xylar
xylar approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@tomvothecoder tomvothecoder merged commit 0a89e8f into main Jan 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xylar xylar xylar approved these changes

Assignees

@tomvothecoder tomvothecoder

Labels
update version Code specifically to update the version
Projects
None yet
Milestone
FY25 Q2 (01/01/25 - 03/31/25)
Development

Successfully merging this pull request may close these issues.

Remove esmpy from dependencies
2 participants
@tomvothecoder @xylar