Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW3-MPAS-SI Coupling for E3SMv3 #1

Open
wants to merge 8 commits into
base: e3sm
Choose a base branch
from

Conversation

erinethomas
Copy link

Pull Request Summary

This PR implements several changes to the WW3 model for wave-sea ice coupling.

Description

This PR makes several changes to the WW3 code base. The major changes include:

  1. adding a new 'switch' file with the sea ice settings for wave-sea ice coupling in E3SM (IC4, IS0).
  2. implementing the new wave attenuation scheme for waves in sea ice based on Meylan et al. (https://doi.org/10.1016/j.ocemod.2021.101779). In the E3SM branch of WW3: this setting is "IC4 Method 8".
    This attenuation scheme takes into consideration damping in sea ice due to scattering, so scattering term must be turned off (IS0 used in new switch file) to avoid 'double counting' effects due to scattering in sea ice.
  3. Lastly, this PR includes an update to the numerics calculation for IC4 based on calculations from Cecilia Bitz. It is numerically more accurate to determine the attenuation of waves in sea ice THEN determine the breaking of ice due to the damped waves. This numerics fix is expected to be merged into the official NOAA/EMC branch of WW3 and is being discussed here: Improve numerical solution for waves in sea ice NOAA-EMC/WW3#738

@erinethomas
Copy link
Author

@sbrus89 - your review is requested.

@sbrus89 sbrus89 self-requested a review July 15, 2024 14:13
@sbrus89 sbrus89 self-assigned this Jul 15, 2024
DO T=1,NTH
INSPC(K,T)=BT(K)*INSPC(K,T)/TPI/(WN2(K)**3.0)/AVG
ENDDO
IF (AVG .GT. 0.0) THEN

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a slightly different coding of this fix in the WW3 main.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for noticing @dabail10 - I will double check

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thans Dave - fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants