Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some basic notes on time stepping design #95

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mwarusz
Copy link
Member

@mwarusz mwarusz commented Jul 3, 2024

  • Documentation:
    • Design document has been generated and added to the docs
    • Documentation has been built locally and changes look as expected

@mwarusz mwarusz force-pushed the mwarusz/omega/ts-design branch from e8f1349 to 9340256 Compare July 3, 2024 15:21
@mwarusz mwarusz requested a review from hyungyukang July 3, 2024 15:23
@philipwjones
Copy link

Should have added this to the original design doc, but to follow up on my comments during the call, we need a requirement for the full ocean model to be able to mix time stepping schemes, not only by variable but also by individual tendencies. For example, we will always do vertical mixing with a fully implicit scheme. And for tracers, we may use a different scheme for advection (sometimes consistent with momentum, but maybe SLT brings its own) vs mixing terms. And of course barotropic splitting which will add its own complications.

@mwarusz mwarusz force-pushed the mwarusz/omega/ts-design branch from 9340256 to 0a5cfe3 Compare July 3, 2024 15:34
@mwarusz mwarusz force-pushed the mwarusz/omega/ts-design branch from 0a5cfe3 to 98a1439 Compare July 3, 2024 15:35
Copy link

@philipwjones philipwjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document might be ok for version-0, but I really think it would benefit from thinking about, and designing for the full complexity of the final model. This includes adding requirements for

  • barotropic splitting, both implicit and explicit-subcycling
  • separate momentum and tracer timesteps (tracer super-cycling)
  • support for regional timesteps?
  • blending time integration schemes as needed in a consistent way

I don't think this current design will be able to support any of this unless doStep becomes the analog of the mpas time_integration_xxxxx routines for every possible combination of options. I'd like to see a little more thought up front about how to more flexibly support all these options. I realize with the time crunch we may need to put something simple in place now, so understand if we need to do so.

@mwarusz mwarusz marked this pull request as draft July 10, 2024 15:34
@mwarusz
Copy link
Member Author

mwarusz commented Jul 10, 2024

@philipwjones
I agree that the design I proposed is probably too restrictive and requires more thought. I am converting this PR to a draft for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants