Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix valgrind error in atm proc DAG creation #6890

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix valgrind error in atm proc DAG creation #6890

wants to merge 2 commits into from
+10 −9

Conversation

bartgol
Copy link
Contributor

@bartgol bartgol commented Jan 10, 2025

The issue was simply that we were grabbing a ref to an element in a vector that was later resized, invalidating the ref.

@bartgol bartgol added bug fix PR BFB PR leaves answers BFB EAMxx PRs focused on capabilities for EAMxx labels Jan 10, 2025
@bartgol bartgol requested a review from mjs271 January 10, 2025 23:52
@bartgol bartgol self-assigned this Jan 10, 2025
mjs271
mjs271 approved these changes Jan 11, 2025
View reviewed changes
Copy link

@mjs271 mjs271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch--thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjs271 mjs271 mjs271 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@bartgol bartgol

Labels
BFB PR leaves answers BFB bug fix PR EAMxx PRs focused on capabilities for EAMxx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartgol @mjs271