EAMxx: create rrtmgp allsky baseline target with CreateUnitTest utility #6875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cmake utility links (indirectly) against scream_io, which avoids link errors in case of shared libraries. The errors are due to the fact that scream_share does use scream_io stuff, but the rrtmgp executable was not linking against it. Since the exec was indeed not using ANY of the scream_io symbols, static linking is fine, but dynamic linking is not.
bartgol
added
bug fix PR
Testing
tcclevenger
approved these changes
Jan 8, 2025
|
Just the expected failures from MAM as in master. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue in eamxx build system when we generate baselines using shared libs.
The cmake utility links (indirectly) against scream_io, which avoids link errors in case of shared libraries. The errors are due to the fact that scream_share does use scream_io stuff, but the rrtmgp executable was not linking against it (directly or indirectly). However, since the exec was indeed not using ANY of the scream_io symbols, static linking is fine, but dynamic linking is not (one of the key differences in static vs dynamic linking).