Bug fix for changing orodrag tuning parameters via namelist #6869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: control/runtime_opts.F90 modified: physics/cam/clubb_intr.F90 modified: physics/cam/gw_drag.F90 modified: physics/cam/od_common.F90 modified: physics/cam/phys_control.F90 [BFB]
|
whannah1
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix for the latest orodrag parameterization merged into master. The setup of the parameter tuning for the schemes is intended to read in orodrag parameters such as od_ls_ncleff, od_bl_ncd, od_ss_sncleff into the model for tuning via phys_control.F90. However, the orodrag parameters are set in a separate place spot in atm_in (e.g. oro_drag_nl), and thus a separate oro_drag_readnl is added in od_common.F90 to read these parameters in atm_in. It is tested and works well both use the new od schemes or the default schemes.
Git log
Fixed the namelist bug for changing tuning par in oro_drag.
modified: control/runtime_opts.F90
modified: physics/cam/clubb_intr.F90
modified: physics/cam/gw_drag.F90
modified: physics/cam/od_common.F90
modified: physics/cam/phys_control.F90
[BFB]