Fix potential uninitialised variable bug in E3SM buildlib files. #6868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove the addition of .DS_store and the change to fates/main/FatesHistoryInterfaceMod.F90 |
At least with my computer, the compilation was crashing because netcdf_args could be uninitialised because it was defined inside an if/elif block that had no else.
mpaiao
force-pushed
the
mpaiao-pr-initfix
branch
from
425b180 to
66cb598
Compare
Done! |
rljacob
changed the title
rljacob
added a commit
that referenced
this pull request
Jan 22, 2025
Add an else clause to two blocks in buildlib that are missing one. [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an else clause to two blocks in buildlib that are missing one.
[BFB]
At least with my computer, the compilation was issuing an "uninitialised risk" error. My understanding is that this risk occurs because variable
netcdf_argswas defined inside anif/elifblock that had noelse. My edits define a dummy value fornetcdf_argsthat is empty for theelsecase.