Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential uninitialised variable bug in E3SM buildlib files. #6868

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpaiao
Copy link

@mpaiao mpaiao commented Dec 22, 2024

At least with my computer, the compilation was issuing an "uninitialised risk" error. My understanding is that this risk occurs because variable netcdf_args was defined inside an if/elif block that had no else. My edits define a dummy value for netcdf_args that is empty for the else case.

@rljacob
Copy link
Member

rljacob commented Dec 23, 2024

Please remove the addition of .DS_store and the change to fates/main/FatesHistoryInterfaceMod.F90

At least with my computer, the compilation was crashing because
netcdf_args could be uninitialised because it was defined inside
an if/elif block that had no else.
@mpaiao
Copy link
Author

mpaiao commented Dec 23, 2024

Please remove the addition of .DS_store and the change to fates/main/FatesHistoryInterfaceMod.F90

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants