-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with mpas-seaice restart_contents #6857
Conversation
passes ERS_P512x1.ne30pg2_r05_IcoswISC30E3r5.F2010.pm-cpu_gnu, which was a configuration that was reported to capture the error |
|
Maybe @dqwu might want to test more here, but I tried:
that all passed. Also tried one of the test setups from @dqwu but it ran out of time after 5 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this works, it seems like an easy solution to me. We'll have to be careful not to include variables in packages in "meta-streams" like restart_contents
in the future as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All previously failed tests now pass.
@ndk The 5-minute walltime limit is sufficient to reproduce the issue. However, if the issue is resolved, the normal runtime (approximately 15 minutes) would likely require a 20-minute walltime limit. |
Fix issue with mpas-seaice restart_contents A new field runningMeanRemovedIceRunoff was added in PR #6696 that causes errors in some configurations on pm-cpu and frontier with the gnu compiler. This moves the new field from a shared "meta-stream" to the streams themselves because attached package wasn't getting inherited correctly. Fixes #6855 [BFB]
passes:
merged to next |
merged to master |
A new field runningMeanRemovedIceRunoff was added in PR #6696 that causes errors in some configurations on pm-cpu and frontier with the gnu compiler. This moves the new field from a shared "meta-stream" to the streams themselves because attached package wasn't getting inherited correctly.
Fixes #6855
[BFB]