Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with mpas-seaice restart_contents #6857

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

jonbob
Copy link
Contributor

@jonbob jonbob commented Dec 17, 2024

A new field runningMeanRemovedIceRunoff was added in PR #6696 that causes errors in some configurations on pm-cpu and frontier with the gnu compiler. This moves the new field from a shared "meta-stream" to the streams themselves because attached package wasn't getting inherited correctly.

Fixes #6855
[BFB]

@jonbob jonbob requested review from dqwu and ndkeen December 17, 2024 22:31
@jonbob jonbob self-assigned this Dec 17, 2024
@jonbob
Copy link
Contributor Author

jonbob commented Dec 17, 2024

passes ERS_P512x1.ne30pg2_r05_IcoswISC30E3r5.F2010.pm-cpu_gnu, which was a configuration that was reported to capture the error

Copy link

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6857/
on branch gh-pages at 2024-12-17 22:33 UTC

@ndkeen
Copy link
Contributor

ndkeen commented Dec 18, 2024

Maybe @dqwu might want to test more here, but I tried:

ERS.ne30pg2_r05_IcoswISC30E3r5.F2010.pm-cpu_gnu
ERS_P512x1.ne30pg2_r05_IcoswISC30E3r5.F2010.pm-cpu_gnu
ERS_P512x1.ne30pg2_r05_IcoswISC30E3r5.F2010.pm-cpu_gnu.allactive-nlmaps
ERS_P512x1.ne30pg2_r05_IcoswISC30E3r5.F2010.pm-cpu_intel

that all passed. Also tried one of the test setups from @dqwu but it ran out of time after 5 minutes.

Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, it seems like an easy solution to me. We'll have to be careful not to include variables in packages in "meta-streams" like restart_contents in the future as well.

Copy link
Contributor

@dqwu dqwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All previously failed tests now pass.

@dqwu
Copy link
Contributor

dqwu commented Dec 18, 2024

Maybe @dqwu might want to test more here, but I tried:

ERS.ne30pg2_r05_IcoswISC30E3r5.F2010.pm-cpu_gnu
ERS_P512x1.ne30pg2_r05_IcoswISC30E3r5.F2010.pm-cpu_gnu
ERS_P512x1.ne30pg2_r05_IcoswISC30E3r5.F2010.pm-cpu_gnu.allactive-nlmaps
ERS_P512x1.ne30pg2_r05_IcoswISC30E3r5.F2010.pm-cpu_intel

that all passed. Also tried one of the test setups from @dqwu but it ran out of time after 5 minutes.

@ndk The 5-minute walltime limit is sufficient to reproduce the issue. However, if the issue is resolved, the normal runtime (approximately 15 minutes) would likely require a 20-minute walltime limit.

@jonbob jonbob added mpas-seaice bug fix PR BFB PR leaves answers BFB labels Dec 18, 2024
jonbob added a commit that referenced this pull request Dec 18, 2024
Fix issue with mpas-seaice restart_contents

A new field runningMeanRemovedIceRunoff was added in PR #6696 that
causes errors in some configurations on pm-cpu and frontier with the gnu
compiler. This moves the new field from a shared "meta-stream" to the
streams themselves because attached package wasn't getting inherited
correctly.

Fixes #6855
[BFB]
@jonbob
Copy link
Contributor Author

jonbob commented Dec 18, 2024

passes:

  • SMS_D_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel.allactive-wcprod

merged to next

@jonbob jonbob merged commit aecc186 into master Dec 19, 2024
5 checks passed
@jonbob jonbob deleted the jonbob/seaice/fix-restart-contents branch December 19, 2024 16:10
@jonbob
Copy link
Contributor Author

jonbob commented Dec 19, 2024

merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB bug fix PR mpas-seaice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPAS framework: runningMeanRemovedIceRunoff field inactive on some PEs
4 participants