remove the exact integration in cube_to_target to avoid negative weights #6854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mt5555
approved these changes
Dec 16, 2024
|
Can you describe what the PR does without referring to other github issues? |
|
@rljacob thanks for the suggestion, the description has been updated |
whannah1
reviewed
Dec 17, 2024
| @@ -850,7 +850,8 @@ subroutine side_integral(& | |||
|
|
|||
| if (xseg(1).EQ.xseg(2))then | |||
| slope = bignum | |||
| else if (abs(yseg(1) -yseg(2))<fuzzy_width) then | |||
| !else if (abs(yseg(1) -yseg(2))<fuzzy_width) then !remove the exact integration | |||
There was a problem hiding this comment.
@jsbamboo let's change the wording on the comment on both of the commented lines to something more verbose and clear, I'm thinking:
"this will enable exact integration, which was found to create problematic negative weights"
A better solution would be to just add a logical switch controlled by a flag, but I'm fine with this solution as well.
There was a problem hiding this comment.
thanks! will push a commit with the first solution
rljacob
approved these changes
Dec 17, 2024
whannah1
approved these changes
Dec 17, 2024
|
@mt5555 is this ready? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the negative weights in cube_to_target.
In the experience of using the cube_to_target for regionally refined meshes, we encountered issues with large negative values for terr_target. This generally happened when the dx of the target mesh was comparable/smaller than the dx of the base cube.
@PeterHjortLauritzen helped us to identify the underlying reasons for the negative weights and suggested a solution. The current practice is to keep the exact integration algorithm, but never enable it—
Since the original version of the judgement condition is rich in semantics, the original judgement was not deleted but annotated.