Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAMxx: refactor vertical remapper to handle different top/bot extrapolations #6770

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

bartgol
Copy link
Contributor

@bartgol bartgol commented Nov 22, 2024

In view of unifying the "dataset interpolation" implementations across eamxx, this PR makes the VerticalRemapper a bit more general. Namely:

  • can be constructed from two existing grids (as opposed as assuming tgt grid is from map file);
  • can handle "P0" and "Masked" extrapolation (the former does constant extrapolation, the latter sets extrapolated value to a constant mask value)
  • can do different extrapolations at top and bottom of the column (but same extrapolation type across all columns)
  • can handle 1d as well as 2d pressure profile, for both source and target pressure

Depends-On: #6761

@bartgol bartgol added the EAMxx PRs focused on capabilities for EAMxx label Nov 22, 2024
@bartgol bartgol self-assigned this Nov 22, 2024
Copy link

github-actions bot commented Nov 22, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6770/
on branch gh-pages at 2024-11-26 22:39 UTC

* Allow to build from existing grids
* Handle masked as well as P0 extrapolation
* Handle top/bot extrapolations separately
@bartgol bartgol force-pushed the bartgol/eamxx/vert-remapper-refactor branch from 7722235 to 14df8d2 Compare November 22, 2024 18:20
@rljacob
Copy link
Member

rljacob commented Nov 26, 2024

@AaronDonahue or @tcclevenger please review.

@bartgol
Copy link
Contributor Author

bartgol commented Nov 26, 2024

@tcclevenger is on the road, moving across country.

@AaronDonahue, the CUDA fails are the same as in master. The gh/ci fails are mysterious, but maybe @mahf708 knows what the deal is. That said, it's likely orthogonal to this PR.

@bartgol bartgol closed this Nov 26, 2024
@bartgol bartgol deleted the bartgol/eamxx/vert-remapper-refactor branch November 26, 2024 22:36
@bartgol bartgol restored the bartgol/eamxx/vert-remapper-refactor branch November 26, 2024 22:37
@bartgol bartgol reopened this Nov 26, 2024
@bartgol
Copy link
Contributor Author

bartgol commented Nov 26, 2024

(a)ccidentally deleted the branch)

@bartgol
Copy link
Contributor Author

bartgol commented Nov 27, 2024

The last round of testing showed all passing and the known master diff on CUDA. The ghci-snl runners are having network issues right now, so they are stuck, but nothing changed since the last round of tests, so I'm merging.

@bartgol bartgol merged commit c6e42b6 into master Nov 27, 2024
23 of 38 checks passed
@bartgol bartgol deleted the bartgol/eamxx/vert-remapper-refactor branch November 27, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EAMxx PRs focused on capabilities for EAMxx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants