Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAMxx: Modify microphysics interface to include sethet (washout rates) #6752

Closed
wants to merge 1 commit into from

Conversation

odiazib
Copy link
Contributor

@odiazib odiazib commented Nov 17, 2024

An existing EAMxx interface (eamxx_mam_microphysics_process_interface.cpp) is modified to include the invocation of the washout rates for gases.

Since the CMake option, SCREAM_ENABLE_MAM, is always ON, these codes are always compiled with the EAMxx codebase, but this interface can be turned off/on using the namelist flags.


Output variables

This process computes het_rates that are used in gas phase chemistry

Testing

We have existing tests for this interface, so we didn't add any new tests. We have a suite of validation tests in the MAM4xx repo to validate sethet process

The atmchange command to invoke this process in a CIME simulation is:

./atmchange physics::atm_procs_list="mac_aero_mic,rrtmgp,mam4_aero_microphys

To set up a test with the above configuration, use the following commands:

cd cime/scripts
./create_test SMS_D_P32x1_Ln5.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.<machine>_<compiler>.scream-mam4xx-aero_microphysics -t <test id> -p <project id>

Where,
is the machine name
is the compiler to use on the machine
is a unique string test identifier
is the allocation project to charge

scream-mam4xx-aero_microphysics is the test modifier that adds mam4_aero_microphys to the atm_procs_list process list and increases the number of tracers to 41.

For ne30pg2 grid, use the following command:

./create_test SMS_D_P32x1.ne30pg2_oECv.F2010-SCREAMv1-MPASSI.<machine>_<compiler>.scream-mam4xx-aero_microphysics -t <test id> -p <project id> 

New input data

No new input data

Figures from model analysis

(Coming soon)

Standalone Test Timings (Compy):

We will upload the timings once the PR is reviewed and approved

Copy link
Contributor

@singhbalwinder singhbalwinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks, @odiazib

@singhbalwinder
Copy link
Contributor

Tagging @susburrows

@rljacob rljacob added the EAMxx PRs focused on capabilities for EAMxx label Nov 18, 2024
@rljacob
Copy link
Member

rljacob commented Nov 18, 2024

@bartgol looks like the eamxx testing is working here.

@odiazib
Copy link
Contributor Author

odiazib commented Nov 18, 2024

@bartgol looks like the eamxx testing is working here.

But the tests are not running... They are still pending.

@rljacob
Copy link
Member

rljacob commented Nov 18, 2024

Sorry by "working" I meant the github action is recognizing the eamxx changes and launching the jobs.

@bartgol
Copy link
Contributor

bartgol commented Nov 18, 2024

Sorry by "working" I meant the github action is recognizing the eamxx changes and launching the jobs.

Yes, our runners are configured to only listen to e3sm-project/scream on github. I will try to switch them to e3sm-project/e3sm and see what happens there. I don't think they allow us to share the same runner across projects, even though I think gh allows to have org-level runners

@odiazib odiazib closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EAGLES EAMxx PRs focused on capabilities for EAMxx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants