Set diagnositc ice falling flux as zero to avoid ice double counting in COSP. #6722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…counting in COSP.
|
|
@yunpengshan2014 can you open an issue describing the problem? |
|
Hi Rob,
We have a confluence page describing this problem:
https://acme-climate.atlassian.net/wiki/spaces/ATMOS/pages/edit-v2/4654497798?draftShareId=c179bae8-e00d-4754-8faf-0d05f5eb48a2.
Does it work?
Regards,
Yunpeng
…On Thu, Oct 31, 2024 at 9:55 AM Robert Jacob ***@***.***> wrote:
@yunpengshan2014 <https://github.com/yunpengshan2014> can you open an
issue describing the problem?
—
Reply to this email directly, view it on GitHub
<#6722 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APW7K6MAKMYVHKPNH33AQC3Z6JOINAVCNFSM6AAAAABQ5AWYBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJQGM3DQMZXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
No there needs to be a github issue. |
|
@yunpengshan2014 , look like with the current P3 scheme, the assignment for precip_ice_flux should never exist. I would suggest delete the line altogether, instead of just commenting out. |
|
This PR addresses issue #6735. |
|
@yunpengshan2014 - Would you address @wlin7's comment? Then I can approve the PR. |
|
Notes: will remove instead of just commenting out code. |
|
Thanks, @wlin7! |
crterai
approved these changes
Nov 21, 2024
|
@crterai , I have remove the commented out lines. If ever needed again for diagnostics purpose, the calculations are the same as for |
wlin7
approved these changes
Nov 21, 2024
wlin7
added a commit
that referenced
this pull request
Nov 21, 2024
…6722) Set diagnositc ice falling flux as zero to avoid ice double counting in COSP PR #5827 introduced an unexpected issue affecting the COSP CALIPSO simulator diagnostics. This issue arises from assigning the P3 diagnostic precipitating solid phase particle falling flux to “precip_ice_flux” for diagnostic purposes. Since “precip_ice_flux” is also a required input field and is treated as snow in the CALIPSO simulator, this results in the double-counting of solid phase particles. This is because the E3SMv3 implemented the single-ice category version of P3 as used in SCREAM, where the simulated solid particles are either precipitating or non-precipitating. While assigning the P3 diagnostic precipitating solid phase particle falling flux to “precip_ice_flux” is technically correct, it inadvertently leads to double-counting of ice in the CALIPSO simulator's cloud diagnostics. Note that this issue does not impact model simulations. [BFB] except for tests with COSP CALIPSO simulator output
|
Merged to next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR#5827 introduced an unexpected issue affecting the COSP CALIPSO
simulator diagnostics. This issue arises from assigning the P3 diagnostic
precipitating solid phase particle falling flux to “precip_ice_flux” for
diagnostic purposes. Since “precip_ice_flux” is also a required input field
and is treated as snow in the CALIPSO simulator, this results in the
double-counting of solid phase particles. This is because the E3SMv3
implemented the single-ice category version of P3 as used in SCREAM,
where the simulated solid particles are either precipitating or non-precipitating.
While assigning the P3 diagnostic precipitating solid phase particle falling
flux to “precip_ice_flux” is technically correct, it inadvertently leads to
double-counting of ice in the CALIPSO simulator's cloud diagnostics.
Note that this issue does not impact model simulations.
[BFB] except for tests with COSP CALIPSO simulator output