Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake for oneapi-ifxgpu runs #6715

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

amametjanov
Copy link
Member

Move -Xsycl-target-backend to link flags.

[BFB]

@amametjanov amametjanov added Machine Files BFB PR leaves answers BFB Aurora labels Oct 29, 2024
@amametjanov amametjanov self-assigned this Oct 29, 2024
Copy link

github-actions bot commented Oct 29, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6715/
on branch gh-pages at 2024-11-09 01:26 UTC

Move -Xsycl-target-backend to link flags
@amametjanov amametjanov force-pushed the azamat/oneapi-ifxgpu/update-link-flags branch from e6001f9 to ac93ede Compare November 9, 2024 01:24
@amametjanov
Copy link
Member Author

amametjanov commented Nov 9, 2024

Testing on Aurora:

Testing on Sunspot:

@amametjanov amametjanov marked this pull request as ready for review November 9, 2024 01:48
@rljacob rljacob requested a review from oksanaguba November 11, 2024 03:51
@oksanaguba
Copy link
Contributor

for the gpu tests, the above says 1 out of 2 tests, but the cdash link shows only 1 test, where is the other, failing, one?

why did you test cpu builds? do i understand it right that the files you modified are not used in the cpu builds?

@oksanaguba
Copy link
Contributor

i cannot seem to find SYCL_EXE_LINKER_FLAGS in a recent master, but other machine files are using CMAKE_EXE_LINKER_FLAGS . i also do not remember using ${ARCH}_EXE_LINKER_FLAGS before .

thanks!

@amametjanov
Copy link
Member Author

The cdash link above is now updated to show both e3sm_gpucxx tests.
Yes, this PR has no effect on CPU builds: I ran them to check on the current state of e3sm and scream on Aurora.

This PR separates link flags -Xsycl-target-backend \"-device 12.60.7\" from compile flags in SYCL_FLAGS to clean-up warnings like

icpx: warning: argument unused during compilation: '-Xsycl-target-backend -device 12.60.7'

In E3SM builds, these flags are already in CMAKE_EXE_LINKER_FLAGS in this cmake line.
They are in a new SYCL_EXE_LINKER_FLAGS cmake-var for standalone Omega builds here.
Adding the link flags to existing CMAKE_EXE_LINKER_FLAGS cmake-var breaks builds for other libs like mct.

@oksanaguba
Copy link
Contributor

oksanaguba commented Nov 15, 2024

if i understood it right, then SYCL_EXE_LINKER_FLAGS is a bad name, as it is used only by omega ('omega' should show up in the name). now i lost access to my builds, but it seems the issue will resurface in https://github.com/E3SM-Project/scream/pull/2593/files# where i used vars like SYCL_LINK_FLAGS . i am very confused about scope of various cmake variables in e3sm builds, and *cmake files for them (separation between e3sm shared libs and scream component). i might create a confl page with questions about this. to add -- also some build flags show up in link line (?).

@rljacob
Copy link
Member

rljacob commented Nov 21, 2024

Notes: will rename variable and then merge.

amametjanov added a commit that referenced this pull request Dec 3, 2024
(PR #6715)

Update CMake for oneapi-ifxgpu runs

Move -Xsycl-target-backend to link flags.

[BFB]
@amametjanov amametjanov merged commit 09b9b7e into master Dec 3, 2024
8 of 9 checks passed
@amametjanov amametjanov deleted the azamat/oneapi-ifxgpu/update-link-flags branch December 3, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aurora BFB PR leaves answers BFB Machine Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants