Chemistry output bug fix

[jinboxie]

Due to a bug in the output of the chemistry reaction rate,
the r_lch4 and r_lco_h are output as 0 when no chemistry output
flags are set. The bug is fixed by modifying the if clause in the code.

Fixes #6711

[BFB]

Git info

1. The output of reaction rate of r_lch4 and r_lco_h are not output due to a bug, fixed it in the code.

   modified: components/eam/src/chemistry/mozart/rate_diags.F90
   [BFB]

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6713/
on branch gh-pages at 2024-11-04 23:35 UTC

[rljacob]

Did you also want this on the maint-3.0 branch?

[jinboxie]

Did you also want this on the maint-3.0 branch?

Yes. Rob @rljacob . The master as of 0305 (which should be that of maint-3.0) is also affected by this bug.

[rljacob]

Then you will have to make a feature branch from before the maint-3.0 branch started and implement it there. This feature branch is after maint-3.0.

Will it change outputs for v3.0 production runs?

[jinboxie]

Then you will have to make a feature branch from before the maint-3.0 branch started and implement it there. This feature branch is after maint-3.0.

Will it change outputs for v3.0 production runs?

Hi Rob @rljacob. I was making a simulation run that needed to validate these variables (r_lch4 and r_lco_h) to find that this code by predecessors seems to have this bug in the code.

These variables are reaction rates not produced by the production runs as we have checked here https://acme-climate.atlassian.net/wiki/spaces/CM/pages/4290281655/v3.LR.amip+simulations. The bug itself only makes the model fail to output these variables values (thus output 0), and should not affect the outputs for v3 production runs.

I'll make a separate maint-3.0 feature branch for it. Thank you for the suggestion :)

Best,
Jinbo

[hsiangheleellnl]

I don't understand the current propose for writing out r_lch4_2D and r_ch4_Lx. Before we need to turn on history_UCIgaschmbudget_2D_levels and hisUCIgasbudget_2D to write out the variables. Now, do we want to write out the variables matter what flag is on? If that is the case, why not just remove the "if" statement. Now, once the history_UCIgaschmbudget_2D_levels and hisUCIgasbudget_2D are on, the variables can not be written out.

[tangq]

@jinboxie , the PR looks good. Pls submit another PR to fix maint-3.0 as suggested by @rljacob

@hsiangheleellnl , the original output of rate_names should not be affected by the history_UCIgaschmbudget* flags, which is why this fix is needed.

[wlin7]

The changes look good to have the output of related rates not affected by the history_UCIgaschmbudget flags.

[jinboxie]

Then you will have to make a feature branch from before the maint-3.0 branch started and implement it there. This feature branch is after maint-3.0.

Will it change outputs for v3.0 production runs?

Hi Rob @rljacob . Please refer to #6716 for the fix for maint-3.0.

[wlin7]

Merged to next.