Enable gh/ci on maint-3.0 #6707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahf708
added
Testing
mahf708
commented
Oct 24, 2024
| branches: [ master ] | ||
| branches: | ||
| - master | ||
| - maint-3.0 |
There was a problem hiding this comment.
Sounds good. Quick clarification: do we usually update maint branches via PRs or manually merging fixes and pushing directly to maint? If the former, all good. Otherwise we may want to change the trigger for maint to a push.
There was a problem hiding this comment.
I think we intend to only allow PRs in general, but @rljacob can confirm
There was a problem hiding this comment.
Yes PRs and the PR issuer has to make sure to change the target to a maint branch.
bartgol
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activate gh/ci workflows on maint-3.0.
[BFB]