Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make L80 default for RRM grids #6698

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make L80 default for RRM grids #6698

wants to merge 1 commit into from

Conversation

wlin7
Copy link
Contributor

@wlin7 wlin7 commented Oct 17, 2024

Delete previous default of L72 for RRM grids.


To further add atm IC files and test

Copy link

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6698/
on branch gh-pages at 2024-10-17 22:21 UTC

@whannah1
Copy link
Contributor

@wlin7 have you generated new initial conditions for the RRM grids?

I worked on this awhile back, but I ran into issues trying to run the RRM cases out long enough to ensure that they were properly adjusted to the new vertical grid.

@tangq
Copy link
Contributor

tangq commented Oct 17, 2024

We may use the atm IC from the current v3.NARRM test, which has completed 50+ years. The IC files are located on Chrysalis at /lcrc/group/e3sm/ac.qtang/E3SMv3_dev/20240905.v3.narrm.hybrid_dt.WCYCL1850.warm.seaice_ocean.chrysalis/archive/rest

@whannah1
Copy link
Contributor

@tangq those files look good for the NA grid - but we still have a test for the conus grid in e3sm_integration:

    #e3sm tests for RRM grids
    "e3sm_rrm" : {
        "tests" : (
            "SMS_D_Ln5.conusx4v1pg2_r05_IcoswISC30E3r5.F2010",
            )
        },

So we either need to update that grid or switch it to use the NA grid.

@tangq
Copy link
Contributor

tangq commented Oct 18, 2024

@whannah1 , good point.

Because v3.NARRM updated to the resolution northamericax4v1pg2_r025_IcoswISC30E3r5, it might make sense to 1) update this new resolution for the e3sm_rrm test on master, and 2) keep the old resolution for the test on the maint branches.

Another option is to interpolate the L72.conusx4v1pg2_r05_IcoswISC30E3r5 IC files to L80 and run multiple years to get the stable ICs and update the tests to use the new L80 ICs.

There could be other options. I am not sure which way is the best and am leaning towards the first method, i.e. 1) and 2) above.

Down the road, when v3.NARRM is finalized we can update the rrm tests on master with the final initial conditions.

@tangq those files look good for the NA grid - but we still have a test for the conus grid in e3sm_integration:

    #e3sm tests for RRM grids
    "e3sm_rrm" : {
        "tests" : (
            "SMS_D_Ln5.conusx4v1pg2_r05_IcoswISC30E3r5.F2010",
            )
        },

So we either need to update that grid or switch it to use the NA grid.

@whannah1
Copy link
Contributor

@tangq what needs to be finalized about v3.NARRM?

Once that's done it might be good to change the tests to use northamericax4v1pg2_r025_IcoswISC30E3r5 and add a default IC file from the final version.

Is there any desire to keep testing the conus grid?
I presume that no one would care if we switch the test to use NARRM

@tangq
Copy link
Contributor

tangq commented Oct 24, 2024

@whannah1 , depending on the test results, v3.NARRM might need to change the ocean time step and some parameters based on the v3.HR setting (e.g., lightning NOx factor).

On the master, we probably only need to test northamericax4v1pg2_r025_IcoswISC30E3r5. As suggested above, the conusx4v1pg2_r05_IcoswISC30E3r5 test can be done on the maint branch only.

@whannah1
Copy link
Contributor

@tangq In that case we can switch the testing now in this PR because it seems the default initial condition won't need to change.

Would you mind uploading an eam.i file from the latest run to the server?

Then we can add it as the default and switch the test on this branch.

@tangq
Copy link
Contributor

tangq commented Oct 24, 2024

I noticed that @wlin7 indicated "To further add atm IC files and test". @wlin7 , have you done this already? If not, I can make a copy of EAM IC from my current test to the data server. Let me know.

@wlin7
Copy link
Contributor Author

wlin7 commented Oct 25, 2024

I noticed that @wlin7 indicated "To further add atm IC files and test". @wlin7 , have you done this already? If not, I can make a copy of EAM IC from my current test to the data server. Let me know.

Hi @tangq , I haven't added the file to the inputdata server. I think you have interpolated file for both 1850 and 1985. We can use the one for 1985 as a generic IC. Or we can use an eam.i generated from your previous v3.NARRM.AMIP run.

@tangq
Copy link
Contributor

tangq commented Oct 25, 2024

Hi @wlin7 , I copied two v3.NARRM.L80 atm IC files to the input data directory /lcrc/group/acme/public_html/inputdata/atm/cam/inic/homme. The file names are:

1850 file: 20240905.v3.narrm.hybrid_dt.WCYCL1850.warm.seaice_ocean.chrysalis.eam.i.0053-01-01-00000.nc
1985 file: 20240811.v3.narrm.hybrid_dt.F20TR.chrysalis.eam.i.2015-01-01-00000.nc

These files should be good as temporary ICs for NARRM.L80 tests.

@rljacob
Copy link
Member

rljacob commented Oct 31, 2024

@wlin7 what is the status of this?

@rljacob
Copy link
Member

rljacob commented Nov 21, 2024

Notes: having trouble creating initial condition files. @wlin7 will work on it.

@tangq
Copy link
Contributor

tangq commented Nov 21, 2024

Notes: having trouble creating initial condition files. @wlin7 will work on it.

@rljacob , the initial files I pointed to above should be ready to use.

@rljacob rljacob changed the title (WIP) Make L80 default for RRM grids Make L80 default for RRM grids Dec 7, 2024
@rljacob
Copy link
Member

rljacob commented Dec 7, 2024

@tangq and @whannah1 one of you needs to approve this.

@rljacob rljacob added the eam label Dec 7, 2024
@rljacob
Copy link
Member

rljacob commented Dec 7, 2024

@wlin7 will this change answers for RRM tests?

@whannah1
Copy link
Contributor

whannah1 commented Dec 9, 2024

@wlin7 @rljacob I'm confused about this because I only see the change to allow RRM to be L80 by default, but there's no changes for the initial condition namelist defaults - don't we need to change these for this to work?

Searching through tests.py I see both conus and northamerica RRM grids - but I'm not sure which ones are actively tested. Also, some of them are the np4 versions. We should take this opportunity to streamline the RRM tests that we want.

Did we decide to only test the northamerica grid? I recall discussing this and concluding that the CONUS tests are faster since the grid is smaller, so it seemed better for general testing of the RRM capability. If we want to keep the conus tests then I can help my the ncdata files for that.

Side note - I'm not a proponent of testing lots of RRM grids just to ensure the input files are present, seems wastefully redundant. However, I'll concede on this point if I'm in the minority.

@rljacob
Copy link
Member

rljacob commented Dec 13, 2024

@wlin7 remind us how this change is enough to switch the default back to L80.

@rljacob
Copy link
Member

rljacob commented Dec 19, 2024

note: yes need to make new IC file for RRM

@rljacob
Copy link
Member

rljacob commented Jan 9, 2025

note: @wlin7 is testing initial files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants