Introduce land ice surface mass balance fields in default runs without MECs/GLC #6682
Conversation
ELM/GLC SMB QICE fields - makes QICE fields in h0 by default
changes should be b4b and just add additional SMB output of what would be passed to mali if we had an active GLC
do not change h2o mass balance
rljacob
requested review from
matthewhoffman
and removed request for
bishtgautam
|
@matthewhoffman please review. |
There was a problem hiding this comment.
@chloewhicker , thanks for this PR, and sorry for the delay in reviewing it. I'm not familiar with this code, but I followed that you are mirroring the qflx_glcice calculations with new _diag versions of the relevant variables, and that all makes sense. I requested a number of code formatting/whitespace changes to make it clearer what the PR is actually doing.
|
Thanks for the feedback Matt - all comments have been addressed in the new commit! |
There was a problem hiding this comment.
@chloewhicker , thanks for making the minor adjustments from my review. This looks good to me! @bishtgautam , would you like to look this over?
| call hist_addfld1d (fname='QICE', units='mm/s', & | ||
| avgflag='A', long_name='ice growth/melt', & | ||
| ptr_col=this%qflx_glcice, l2g_scale_type='ice') | ||
|
|
||
| this%qflx_glcice_frz(begc:endc) = spval | ||
| call hist_addfld1d (fname='QICE_FRZ', units='mm/s', & | ||
| avgflag='A', long_name='ice growth', & | ||
| ptr_col=this%qflx_glcice_frz, l2g_scale_type='ice') | ||
|
|
||
| this%qflx_glcice_melt(begc:endc) = spval | ||
| call hist_addfld1d (fname='QICE_MELT', units='mm/s', & | ||
| avgflag='A', long_name='ice melt', & | ||
| ptr_col=this%qflx_glcice_melt, l2g_scale_type='ice') |
There was a problem hiding this comment.
How about adding diagnostic and (with active GLC/MECs) in the long_name to mirror what is done below?
There was a problem hiding this comment.
@bishtgautam -- does that address your questions?
Introduce land ice surface mass balance fields in default runs without MECs/GLC Introduced new diagnostic Surface Mass Balance fields, they are calculated as if there is a coupled land ice component but are only diagnostic - it does not modify the energy/water budgets in default or coupled GLC simulations. [BFB]
|
passes e3sm_developer on chrysalis except for a few I-cases that show DIFFs due to a change in fieldlists but otherwise BFB merged to next |
|
The additional fields |
|
merged to master and expected DIFFs due only to different field lists blessed -- except for pm-cpu, which had issues overnight |
|
Also blessed on pm-cpu and gcp12 |
Introduced new diagnostic Surface Mass Balance fields, they are calculated as if there is a coupled land ice component but are only diagnostic - it does not modify the energy/water budgets in default or coupled GLC simulations.
[BFB]
More info on modifications and testing can be found here