Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to sea ice bgc registry and history fields #6644

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

njeffery
Copy link
Contributor

@njeffery njeffery commented Sep 24, 2024

-Corrects units/descriptions of bgc fields in registry
-Defines column integrated and cell average bgc diagnostics
-Updates streams build to include new diagnostics for bgc runs

[BFB]

-Corrects units/descriptions of bgc fields in registry
-Defines column integrated and cell average bgc diagnostics
-Updates streams build to include new diagnostics for bgc runs

BFB
Copy link

github-actions bot commented Sep 24, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6644/
on branch gh-pages at 2024-10-09 16:52 UTC

@eclare108213
Copy link
Contributor

@njeffery What kinds of testing have you done on these changes? We need to confirm BFB with the current code and that all of the new fields and diagnostics have reasonable (hopefully correct) output in them. Is there a possibility that runs with some BGC options on and other options off could have misleading or NaN output?

@njeffery
Copy link
Contributor Author

@eclare108213 : I've done a very short 2X5 day ocean-ice with bgc+zaerosols test to verify restartability and BFB. I've also plotted the new diagnostics to verify that they're corrected. I believe the standard checks verify bfb in the physics configuration but @jonbob can confirm.

There is a possibility that bgc on and zaerosols off will produce Nans in some fields. Let me fix that.

@njeffery
Copy link
Contributor Author

@eclare108213 : I've completed a test with zaerosols off and bgc active to verify no NaNs.

I also plotted ocean surface bgc fields and the new sea ice 2D bgc diagnostics to make sure the order of magnitudes are consistent. All the new fields looked consistent. Here's a couple of examples:

Sea ice Algal Carbon

totalVerticalAlgaeCarbonIce-4.pdf

Ocean surface diatom carbon

oceanDiatomCarbon.pdf

Sea ice nitrate

totalVerticalNitrateIce.pdf

Ocean surface nitrate

oceanNitrateSurface.pdf

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only affects output of BGC quantities. I am approving based on developer testing. @jonbob will run the complete E3SM test suite to verify there are no other impacts.

@jonbob jonbob added the BFB PR leaves answers BFB label Oct 9, 2024
jonbob added a commit that referenced this pull request Oct 9, 2024
Updates to sea ice bgc registry and history fields

Several changes including:
* Corrects units/descriptions of bgc fields in registry
* Defines column integrated and cell average bgc diagnostics
* Updates streams build to include new diagnostics for bgc runs

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Oct 9, 2024

Passes:

  • e3sm_ice_developer on chrysalis
  • SMS_Ld2.ne30pg2_r05_IcoswISC30E3r5.BGCEXP_CNTL_CNPRDCTC_1850.chrysalis_intel.elm-bgcexp

merged to next

@jonbob jonbob merged commit 6e216a5 into master Oct 10, 2024
4 of 5 checks passed
@jonbob jonbob deleted the njeffery/seaice/update-bgc-history branch October 10, 2024 15:25
@jonbob
Copy link
Contributor

jonbob commented Oct 10, 2024

merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB mpas-seaice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants